[Media Router] Add MediaSink subtypes

chrome/browser/media/router/mojo/media_router.mojom

Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 37fc064748de40d2a68f17ebec05798d2c3a4871..b3b470f4930ae2c2e50cf259e6e79066bb197927 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -6,6 +6,7 @@ module media_router.mojom;
 
 import "mojo/common/time.mojom";
 import "url/mojo/origin.mojom";
+import "url/mojo/url.mojom";
 
 // Represents an output sink to which media can be routed.
 struct MediaSink {
@@ -27,6 +28,45 @@ struct MediaSink {
   string? domain;
   // The type of icon to show in the UI for this media sink.
   IconType icon_type;
+
+  MediaSinkExtraData? extra_data;

[imcheng, 2017/02/24 23:54:21]

Mention that this is currently only set by MediaRouter in OnSinksDiscovered().

[zhaobin, 2017/02/27 21:45:15]

Done.

+};
+
+union MediaSinkExtraData {
+  DialMediaSink dial_media_sink;
+  CastMediaSink cast_media_sink;
+};
+
+struct DialMediaSink {
+  string ip_address;
+
+  // Model name of the sink, if it represents a physical device.
+  string? model_name;

[imcheng, 2017/02/24 23:54:21]

I think this is no longer optional

[zhaobin, 2017/02/27 21:45:15]

Done.

+
+  // Used for DIAL launch
+  url.mojom.Url app_url;
+};
+
+struct CastMediaSink {
+  string ip_address;
+
+  // Model name of the sink, if it represents a physical device.
+  string? model_name;

[imcheng, 2017/02/24 23:54:21]

Same as above; not optional

[zhaobin, 2017/02/27 21:45:15]

Done.

+
+  // A bit vector representing capabilities of the sink. Meaning of capacity
+  // value for each bit:
+  // NONE: 0,
+  // VIDEO_OUT: 1 << 0,
+  // VIDEO_IN: 1 << 1,
+  // AUDIO_OUT: 1 << 2,
+  // AUDIO_IN: 1 << 3,
+  // DEV_MODE: 1 << 4,
+  // MULTIZONE_GROUP: 1 << 5
+  int32 capabilities;
+
+  // ID of cast channel opened by Media Router. The ID can be
+  // used to send call chrome.cast.channel.send.

[imcheng, 2017/02/24 23:54:21]

nit: the second sentence is probably not necessary.

[mark a. foltz, 2017/02/25 01:10:24]

nit: Cast

I think it would be good to mention that the ID is defined by the
chrome.cast.channel API.

[zhaobin, 2017/02/27 21:45:15]

Done.

+  int32 cast_channel_id;
 };
 
 // Should be kept in sync with media_route.h.