Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

Issue 2675033002: [Media Router] Add MediaSink subtypes (Closed)
Patch Set: add TypedMediaSink class Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
diff --git a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
index fef54c4b0023e00d432349636ec6980561f573c9..433a2da557a5785e77dcd43e7674566a5cc5a9e5 100644
--- a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
+++ b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
@@ -31,10 +31,10 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaSink) {
// Convert MediaSink and back should result in identical object.
EXPECT_EQ(expected_media_sink.name(), media_sink.name());
EXPECT_EQ(expected_media_sink.id(), media_sink.id());
- EXPECT_FALSE(media_sink.description().empty());
- EXPECT_EQ(expected_media_sink.description(), media_sink.description());
- EXPECT_FALSE(media_sink.domain().empty());
- EXPECT_EQ(expected_media_sink.domain(), media_sink.domain());
+ EXPECT_TRUE(media_sink.description());
+ EXPECT_EQ(*expected_media_sink.description(), *media_sink.description());
+ EXPECT_TRUE(media_sink.domain());
+ EXPECT_EQ(*expected_media_sink.domain(), *media_sink.domain());
EXPECT_EQ(expected_media_sink.icon_type(), media_sink.icon_type());
EXPECT_TRUE(expected_media_sink.Equals(media_sink));
}

Powered by Google App Engine
This is Rietveld 408576698