[Media Router] Add MediaSink subtypes

chrome/browser/media/router/media_sink.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/string_compare.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/media/router/media_sink.h"
 #include "third_party/icu/source/i18n/unicode/coll.h"
 
 namespace media_router {
 
 MediaSink::MediaSink(const MediaSink::Id& sink_id,
                      const std::string& name,
                      const MediaSink::IconType icon_type)
-    : sink_id_(sink_id), name_(name), icon_type_(icon_type) {}
+    : type_(SinkType::GENERAL),

[imcheng, 2017/02/08 01:28:08]

We can define a protected MediaSink constructor that takes a SinkType in
addition to the existing 3 arguments. Then this constructor and the Dial / Cast
MediaSink constructors can call it. WDYT?

[zhaobin, 2017/02/09 00:13:52]

Done.

+      sink_id_(sink_id),
+      name_(name),
+      icon_type_(icon_type) {}
 
 MediaSink::MediaSink(const MediaSink& other) = default;
 
 MediaSink::~MediaSink() {
 }
 
 bool MediaSink::Equals(const MediaSink& other) const {
   return sink_id_ == other.sink_id_;
 }
 
@@ skipping 14 matching lines @@
     // available.
     int val = name_.compare(other.name_);
     if (val)
       return val < 0;
   }
 
   return sink_id_ < other.sink_id_;
 }
 
 }  // namespace media_router