Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: extensions/renderer/dispatcher.cc

Issue 2675033002: [Media Router] Add MediaSink subtypes (Closed)
Patch Set: resolve code review comments from Derek and Mark Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/renderer/resources/extensions_renderer_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/dispatcher.h" 5 #include "extensions/renderer/dispatcher.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 737
738 // Custom types sources. 738 // Custom types sources.
739 {"StorageArea", IDR_STORAGE_AREA_JS}, 739 {"StorageArea", IDR_STORAGE_AREA_JS},
740 740
741 // Platform app sources that are not API-specific.. 741 // Platform app sources that are not API-specific..
742 {"platformApp", IDR_PLATFORM_APP_JS}, 742 {"platformApp", IDR_PLATFORM_APP_JS},
743 743
744 #if defined(ENABLE_MEDIA_ROUTER) 744 #if defined(ENABLE_MEDIA_ROUTER)
745 {"chrome/browser/media/router/mojo/media_router.mojom", 745 {"chrome/browser/media/router/mojo/media_router.mojom",
746 IDR_MEDIA_ROUTER_MOJOM_JS}, 746 IDR_MEDIA_ROUTER_MOJOM_JS},
747 {"media_router_bindings", IDR_MEDIA_ROUTER_BINDINGS_JS},
747 {"mojo/common/time.mojom", IDR_MOJO_TIME_MOJOM_JS}, 748 {"mojo/common/time.mojom", IDR_MOJO_TIME_MOJOM_JS},
749 {"net/interfaces/ip_address.mojom", IDR_MOJO_IP_ADDRESS_MOJOM_JS},
748 {"url/mojo/origin.mojom", IDR_ORIGIN_MOJOM_JS}, 750 {"url/mojo/origin.mojom", IDR_ORIGIN_MOJOM_JS},
749 {"media_router_bindings", IDR_MEDIA_ROUTER_BINDINGS_JS}, 751 {"url/mojo/url.mojom", IDR_MOJO_URL_MOJOM_JS},
750 #endif // defined(ENABLE_MEDIA_ROUTER) 752 #endif // defined(ENABLE_MEDIA_ROUTER)
751 }; 753 };
752 754
753 if (base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames)) { 755 if (base::FeatureList::IsEnabled(::features::kGuestViewCrossProcessFrames)) {
754 resources.emplace_back("guestViewIframe", IDR_GUEST_VIEW_IFRAME_JS); 756 resources.emplace_back("guestViewIframe", IDR_GUEST_VIEW_IFRAME_JS);
755 resources.emplace_back("guestViewIframeContainer", 757 resources.emplace_back("guestViewIframeContainer",
756 IDR_GUEST_VIEW_IFRAME_CONTAINER_JS); 758 IDR_GUEST_VIEW_IFRAME_CONTAINER_JS);
757 } 759 }
758 760
759 return resources; 761 return resources;
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
1408 // The "guestViewDeny" module must always be loaded last. It registers 1410 // The "guestViewDeny" module must always be loaded last. It registers
1409 // error-providing custom elements for the GuestView types that are not 1411 // error-providing custom elements for the GuestView types that are not
1410 // available, and thus all of those types must have been checked and loaded 1412 // available, and thus all of those types must have been checked and loaded
1411 // (or not loaded) beforehand. 1413 // (or not loaded) beforehand.
1412 if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) { 1414 if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
1413 module_system->Require("guestViewDeny"); 1415 module_system->Require("guestViewDeny");
1414 } 1416 }
1415 } 1417 }
1416 1418
1417 } // namespace extensions 1419 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/BUILD.gn ('k') | extensions/renderer/resources/extensions_renderer_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698