Temporarily allow to import dart:io in client apps.

Temporarily allow to import dart:io in client apps.

Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=lrn@google.com, sra@google.com, dgrove@google.com, kevmoo@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac6bf5926f60e81454ec5d2350a12b50d8b7481e

[Siggi Cherem (dart-lang), 2017-02-03 23:13:58]

Description was changed from

==========
Temporarily allow to import dart:io in client apps.

Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=kevmoo@google.com,dgrove@google.com,sra@google.com
==========

to

==========
Temporarily allow to import dart:io in client apps.

Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=kevmoo@google.com,dgrove@google.com,sra@google.com,lrn@google.com
==========

[Siggi Cherem (dart-lang), 2017-02-03 23:13:58]

sigmund@google.com changed reviewers:
+ lrn@google.com

[Siggi Cherem (dart-lang), 2017-02-04 00:18:55]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-02-04 00:21:21]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-02-04 00:22:57]

Patchset #1 (id:40001) has been deleted

[Lasse Reichstein Nielsen, 2017-02-05 11:02:01]

LGTM

[sra1, 2017-02-07 21:33:48]

lgtm

https://codereview.chromium.org/2675023002/diff/60001/pkg/compiler/lib/src/ap...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/2675023002/diff/60001/pkg/compiler/lib/src/ap...
pkg/compiler/lib/src/apiimpl.dart:397: // Note: we return false on `dart:io`
here, even if we allow users to
'false' -> 'null' ?

[Siggi Cherem (dart-lang), 2017-02-07 22:02:02]

thanks

https://codereview.chromium.org/2675023002/diff/60001/pkg/compiler/lib/src/ap...
File pkg/compiler/lib/src/apiimpl.dart (right):

https://codereview.chromium.org/2675023002/diff/60001/pkg/compiler/lib/src/ap...
pkg/compiler/lib/src/apiimpl.dart:397: // Note: we return false on `dart:io`
here, even if we allow users to
On 2017/02/07 21:33:48, sra1 wrote:
> 'false' -> 'null' ?

Done.

[Siggi Cherem (dart-lang), 2017-02-07 22:02:11]

Description was changed from

==========
Temporarily allow to import dart:io in client apps.

Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=kevmoo@google.com,dgrove@google.com,sra@google.com,lrn@google.com
==========

to

==========
Temporarily allow to import dart:io in client apps.

Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=lrn@google.com, sra@google.com, dgrove@google.com, kevmoo@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ac6bf5926f60e81454ec5d2350a12b50d8b7481e
==========

[Siggi Cherem (dart-lang), 2017-02-07 22:02:13]

Committed patchset #2 (id:80001) manually as
ac6bf5926f60e81454ec5d2350a12b50d8b7481e (presubmit successful).