Only generate suggested filenames when actually dragging an image.

components/test_runner/event_sender.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/event_sender.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/test_runner/mock_spell_check.h"
 #include "components/test_runner/test_interfaces.h"
 #include "components/test_runner/web_test_delegate.h"
 #include "components/test_runner/web_view_test_proxy.h"
 #include "components/test_runner/web_widget_test_proxy.h"
 #include "gin/handle.h"
 #include "gin/object_template_builder.h"
 #include "gin/wrappable.h"
+#include "net/base/filename_util.h"
+#include "third_party/WebKit/public/platform/URLConversion.h"
 #include "third_party/WebKit/public/platform/WebCoalescedInputEvent.h"
 #include "third_party/WebKit/public/platform/WebGestureEvent.h"
 #include "third_party/WebKit/public/platform/WebKeyboardEvent.h"
 #include "third_party/WebKit/public/platform/WebPointerProperties.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebTouchEvent.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/web/WebContextMenuData.h"
 #include "third_party/WebKit/public/web/WebFrameWidget.h"
 #include "third_party/WebKit/public/web/WebKit.h"
@@ skipping 16 matching lines @@
 using blink::WebLocalFrame;
 using blink::WebMenuItemInfo;
 using blink::WebMouseEvent;
 using blink::WebMouseWheelEvent;
 using blink::WebPagePopup;
 using blink::WebPoint;
 using blink::WebPointerProperties;
 using blink::WebString;
 using blink::WebTouchEvent;
 using blink::WebTouchPoint;
+using blink::WebURL;
 using blink::WebVector;
 using blink::WebView;
 
 namespace test_runner {
 
 namespace {
 
 const int kRawMousePointerId = -1;
 const char* const kPointerTypeStringUnknown = "";
 const char* const kPointerTypeStringMouse = "mouse";
@@ skipping 1808 matching lines @@
 }
 
 void EventSender::SetTouchCancelable(bool cancelable) {
   touch_cancelable_ = cancelable;
 }
 
 void EventSender::DumpFilenameBeingDragged() {
   if (current_drag_data_.isNull())
     return;
 
-  WebString filename;
   WebVector<WebDragData::Item> items = current_drag_data_.items();
   for (size_t i = 0; i < items.size(); ++i) {
     if (items[i].storageType == WebDragData::Item::StorageTypeBinaryData) {
-      filename = items[i].title;
-      break;
+      WebURL url = items[i].binaryDataSourceURL;
+      WebString filename_extension = items[i].binaryDataFilenameExtension;
+      WebString content_disposition = items[i].binaryDataContentDisposition;
+      base::FilePath filename =
+          net::GenerateFileName(url, content_disposition.utf8(),
+                                std::string(),   // referrer_charset
+                                std::string(),   // suggested_name
+                                std::string(),   // mime_type
+                                std::string());  // default_name
+#if defined(OS_WIN)
+      filename = filename.ReplaceExtension(filename_extension.utf16());
+#else
+      filename = filename.ReplaceExtension(filename_extension.utf8());

[kinuko, 2017/02/06 22:24:58]

nit: could we use WebStringToFilePath(filename_extension).value() instead?

[dcheng, 2017/02/08 00:01:05]

I considered this, but a FilePath isn't really "just" a string. While it's not
implemented like this today, it's possible that a future world would add
canonicalization to the constructor, which might change the returned string from
FilePath::value().

Another alternative I considered is WebStringToFilePathStringType()... if you
think that would be better, I'm happy to add it.

+#endif
+      delegate()->PrintMessage(std::string("Filename being dragged: ") +
+                               filename.AsUTF8Unsafe() + "\n");
+      return;
     }
   }
-  delegate()->PrintMessage(std::string("Filename being dragged: ") +
-                           filename.utf8().data() + "\n");
 }
 
 void EventSender::GestureFlingCancel() {
   WebGestureEvent event(WebInputEvent::GestureFlingCancel,
                         WebInputEvent::NoModifiers, GetCurrentEventTimeSec());
   // Generally it won't matter what device we use here, and since it might
   // be cumbersome to expect all callers to specify a device, we'll just
   // choose Touchpad here.
   event.sourceDevice = blink::WebGestureDeviceTouchpad;
 
@@ skipping 988 matching lines @@
   return view()->mainFrame()->toWebLocalFrame()->frameWidget();
 }
 
 std::unique_ptr<WebInputEvent> EventSender::TransformScreenToWidgetCoordinates(
     const WebInputEvent& event) {
   return delegate()->TransformScreenToWidgetCoordinates(
       web_widget_test_proxy_base_, event);
 }
 
 }  // namespace test_runner