Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2674883004: Apply dotted underline style to <abbr> (Closed)

Created:
3 years, 10 months ago by Sunny
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply dotted underline style to <abbr> and <acronym> Add a new rule to user agent stylesheet per sepc. (https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3) BUG=376160

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/html/text-level-semantics/abbr-acronym-rendering.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/html/text-level-semantics/abbr-acronym-rendering-expected.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/html.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Sunny
Hi tkent@, I've run blink tests locally but since it doesn't work correctly, I cannot ...
3 years, 10 months ago (2017-02-04 16:57:48 UTC) #2
tkent
This needs a rendering test, a pixel test or a reference test. A reference test ...
3 years, 10 months ago (2017-02-06 23:24:10 UTC) #7
Sunny
Hi tkent@, PTAL, thanks~
3 years, 10 months ago (2017-02-20 12:49:32 UTC) #8
tkent
lgtm
3 years, 10 months ago (2017-02-20 23:26:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674883004/20001
3 years, 10 months ago (2017-02-20 23:26:17 UTC) #16
tkent
I created a chromestatus entry for this change; https://www.chromestatus.com/feature/4774625963671552 I don't think this needs intent-to-ship.
3 years, 10 months ago (2017-02-20 23:26:48 UTC) #17
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 10 months ago (2017-02-20 23:35:41 UTC) #20
tkent
3 years, 10 months ago (2017-02-20 23:38:54 UTC) #21
On 2017/02/20 at 23:35:41, commit-bot wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the issue was successfully committed. Please check Git history manually and
re-check CQ or close this issue as needed.

This was landed successfully.  Closing.

Powered by Google App Engine
This is Rietveld 408576698