Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2674863004: Add a test that server does not send errors when errors have been disabled (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test that server does not send errors when errors have been disabled R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2f81decdd70f6db4a23c33f4124a622d1779c795

Patch Set 1 #

Patch Set 2 : Added driver version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 3 chunks +45 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-03 22:01:11 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-04 03:19:03 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-04 17:47:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f81decdd70f6db4a23c33f4124a622d1779c795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698