Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 267483002: Update the list of bots in rebaseline.py. (Closed)

Created:
6 years, 7 months ago by Stephen White
Modified:
6 years, 7 months ago
Reviewers:
epoger, borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update the list of bots in rebaseline.py. This script was not updated for the new Ubuntu bots. Also, it was attempting to rebaseline some bots for which we don't keep results (NVPR, ASAN). R=borenet@google.com, borenet Committed: https://code.google.com/p/skia/source/detail?r=14472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M tools/rebaseline.py View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
borenet@: PTAL. Thanks!
6 years, 7 months ago (2014-04-30 15:21:10 UTC) #1
borenet
LGTM, but: 1. Can we (finally) get rid of this hard-coded list? 2. Is rebaseline ...
6 years, 7 months ago (2014-04-30 15:40:42 UTC) #2
Stephen White
On 2014/04/30 15:40:42, borenet wrote: > LGTM, but: > > 1. Can we (finally) get ...
6 years, 7 months ago (2014-04-30 16:11:20 UTC) #3
Stephen White
Committed patchset #1 manually as r14472 (presubmit successful).
6 years, 7 months ago (2014-04-30 16:11:54 UTC) #4
epoger
6 years, 7 months ago (2014-04-30 16:55:10 UTC) #5
Message was sent while issue was closed.
On 2014/04/30 16:11:20, Stephen White wrote:
> On 2014/04/30 15:40:42, borenet wrote:
> > LGTM, but:
> > 
> > 1. Can we (finally) get rid of this hard-coded list?
> 
> Sure. I think this dates from when the bots were named differently on autogen
> (now GS)
> and in the expectations. Logged as
> https://code.google.com/p/skia/issues/detail?id=2500.
> Looks we could just pull it from a dirlist of expectations/gm/Test-*;
> would that work?
> 
> > 2. Is rebaseline server not working, or not in a good-enough state to
replace
> > this script?
> 
> Partly I'm just a Luddite, but also note that this script is able to work when
> the
> rebaseline server is down (this happened recently).

Yesterday's http://skbug.com/2474 ('rebaseline server is down') was caused by
the part of rebaseline_server that automatically gets the list of platforms to
rebaseline... so if rebaseline.py didn't have the hard-coded list, it would have
failed too.

rebaseline.py is unsupported.

Powered by Google App Engine
This is Rietveld 408576698