Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2674813004: dart2js: Keep refined type for type checks (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Keep refined type for type checks The generated code for inserted receiver and argument type checks depends on the input type. Keeping the type after removing HTypeKnown refinements give better code. In a large app, 58% of the 'int' tests are replaced with cheaper 'num' tests on the basis of the more precise input type. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/435da5d44bbab17b5c6acfade591e984fa22034f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +7 lines, -6 lines 1 comment Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 10 months ago (2017-02-03 21:39:26 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2674813004/diff/1/pkg/compiler/lib/src/ssa/codegen.dart File pkg/compiler/lib/src/ssa/codegen.dart (right): https://codereview.chromium.org/2674813004/diff/1/pkg/compiler/lib/src/ssa/codegen.dart#newcode2820 pkg/compiler/lib/src/ssa/codegen.dart:2820: isIntCheck && inputType.nonNullable().containsOnlyInt(closedWorld); I think it's fine to ...
3 years, 10 months ago (2017-02-03 21:48:17 UTC) #3
sra1
3 years, 10 months ago (2017-02-04 00:33:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
435da5d44bbab17b5c6acfade591e984fa22034f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698