Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 267473002: Move sandbox_database_test_helper from webkit/ to content/ (Closed)

Created:
6 years, 7 months ago by pilgrim_google
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik
Visibility:
Public.

Description

Move sandbox_database_test_helper from webkit/ to content/ BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267557

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -135 lines) Patch
A + content/browser/fileapi/sandbox_database_test_helper.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/fileapi/sandbox_database_test_helper.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/browser/fileapi/sandbox_database_test_helper.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/browser/fileapi/sandbox_database_test_helper.cc View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
pilgrim_google
6 years, 7 months ago (2014-04-30 14:22:30 UTC) #1
jam
lgtm
6 years, 7 months ago (2014-04-30 16:16:17 UTC) #2
ericu
LGTM
6 years, 7 months ago (2014-04-30 17:04:30 UTC) #3
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-04-30 17:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/267473002/1
6 years, 7 months ago (2014-04-30 17:44:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 17:49:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 17:49:02 UTC) #7
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-04-30 17:52:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/267473002/1
6 years, 7 months ago (2014-04-30 17:53:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:40:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 18:40:17 UTC) #11
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-04-30 19:21:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/267473002/1
6 years, 7 months ago (2014-04-30 19:22:52 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 03:20:00 UTC) #14
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 7 months ago (2014-05-01 03:20:01 UTC) #15
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-05-01 13:51:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/267473002/20001
6 years, 7 months ago (2014-05-01 13:51:23 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 14:02:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 14:02:37 UTC) #19
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-05-01 14:12:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/267473002/20001
6 years, 7 months ago (2014-05-01 14:12:40 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 17:18:54 UTC) #22
Message was sent while issue was closed. 
Change committed as 267557

Powered by Google App Engine
This is Rietveld 408576698