Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 26747004: Add option to restart usb on device status check before performing check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add restart-usb option for bots to pass to device status check. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 64f9e09218144fbd8647ede7574d920fb09b7498..8deb7378205dc3368f8368351712df3f3ba54bca 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -309,10 +309,12 @@ def ProvisionDevices(options):
RunCmd(provision_cmd)
-def DeviceStatusCheck(_):
+def DeviceStatusCheck(options):
bb_annotations.PrintNamedStep('device_status_check')
- RunCmd(['build/android/buildbot/bb_device_status_check.py'],
- halt_on_failure=True)
+ cmd = ['build/android/buildbot/bb_device_status_check.py']
+ if options.restart_usb:
+ cmd.append('--restart-usb')
+ RunCmd(cmd, halt_on_failure=True)
def GetDeviceSetupStepCmds():
@@ -463,6 +465,8 @@ def GetDeviceStepsOptParser():
parser.add_option('--coverage-bucket',
help=('Bucket name to store coverage results. Coverage is '
'only run if this is set.'))
+ parser.add_option('--restart-usb', action='store_true',
+ help='Restart usb ports before device status check.')
parser.add_option(
'--flakiness-server',
help='The flakiness dashboard server to which the results should be '

Powered by Google App Engine
This is Rietveld 408576698