Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 267463003: Create copy of context record before passing it to StackWalk64 (Closed)

Created:
6 years, 7 months ago by marcing
Modified:
6 years, 7 months ago
Reviewers:
M-A Ruel, awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create copy of context record before passing it to StackWalk64 StackWalk64 may modify EXCEPTION_POINTERS struct that is passed to it from constructor of StackTrace. In the case of StackDumpExceptionFilter the struct that is passed to constructor of StackTrace may be later passed to other (chained) exception filter(s), so it shouldn't be modified. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M base/debug/stack_trace.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_win.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
marcing
6 years, 7 months ago (2014-04-30 18:56:58 UTC) #1
awong
LGTM
6 years, 7 months ago (2014-05-02 19:07:16 UTC) #2
awong
On 2014/05/02 19:07:16, awong wrote: > LGTM nice fix.
6 years, 7 months ago (2014-05-02 19:07:22 UTC) #3
marcing
On 2014/05/02 19:07:22, awong wrote: > On 2014/05/02 19:07:16, awong wrote: > > LGTM > ...
6 years, 7 months ago (2014-05-05 15:38:21 UTC) #4
awong
Oh sorry. I didn't realize you were waiting on me. Still LGTM. On 2014/05/05 15:38:21, ...
6 years, 7 months ago (2014-05-07 21:48:00 UTC) #5
marcing
The CQ bit was checked by marcing@opera.com
6 years, 7 months ago (2014-05-08 10:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marcing@opera.com/267463003/1
6 years, 7 months ago (2014-05-08 10:14:17 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 14:54:05 UTC) #8
Message was sent while issue was closed.
Change committed as 269296

Powered by Google App Engine
This is Rietveld 408576698