Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: test/mjsunit/strong-rooted-literals.js

Issue 2674593003: [TypeFeedbackVector] Root feedback vectors at function literal site. (Closed)
Patch Set: REBASE+liveedit fix. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/unittests/interpreter/interpreter-assembler-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong-rooted-literals.js
diff --git a/test/mjsunit/strong-rooted-literals.js b/test/mjsunit/strong-rooted-literals.js
new file mode 100644
index 0000000000000000000000000000000000000000..005a03934ea318f1e4a13df0a5fcc228c15000b3
--- /dev/null
+++ b/test/mjsunit/strong-rooted-literals.js
@@ -0,0 +1,55 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax --expose-gc --turbo
+
+// Make sure literals are strongly rooted and safe from weak-code deopts.
+
+(function() {
+ function foo() {
+ var a = {y: 0};
+ a.y = 1;
+ return a;
+ }
+
+ foo();
+ foo();
+ % OptimizeFunctionOnNextCall(foo);
+ foo();
+ gc();
+ assertOptimized(foo);
+})();
+
+(function() {
+ function hot(o) {
+ return o.x + o.y;
+ }
+ function mapPlus(a, y) {
+ return a.map(x => hot({x, y}));
+ }
+
+ var a = [1, 2, 3];
+ print(mapPlus(a, 1));
+ print(mapPlus(a, 2));
+ % OptimizeFunctionOnNextCall(hot);
+ print(mapPlus(a, 3));
+ gc(); // BOOOM!
+ assertOptimized(hot);
+ print(mapPlus(a, 4));
+})();
+
+// Verify that we can handle the creation of a new script, where the
+// code is cached and the feedback vector has to be re-created.
+(function() {
+ var sopen = 'function wrapper() { ';
+ var s1 = 'function foo() { return bar(5); } ';
+ var s2 = 'foo(); foo(); %OptimizeFunctionOnNextCall(foo); foo(); ';
+ var sclose = '} wrapper(); ';
+ var s = sopen + s1 + s2 + sclose;
+ function bar(i){return i + 3};
+
+ for (var i = 0; i < 4; i++) {
+ eval(s);
+ }
+})();
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/unittests/interpreter/interpreter-assembler-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698