Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2674583003: Adapt String::find method via StringUtil adapter. [inspector_protocol repo] (Closed)

Created:
3 years, 10 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adapt String::find method via StringUtil adapter. This is needed to insulate generated code from blink::protocol namespace from naming changes that we plan to do in the Great Blink Rename (which in particular will rename wtf::StringBuilder::find method into Find). BUG=683447 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol1a7cbe8ba8fa0d622586f549a97c73d9b52efbea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/DispatcherBase_cpp.template View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Łukasz Anforowicz
dgozman@, could you PTAL?
3 years, 10 months ago (2017-02-02 21:19:48 UTC) #3
dgozman
lgtm
3 years, 10 months ago (2017-02-03 20:43:46 UTC) #4
Łukasz Anforowicz
3 years, 10 months ago (2017-02-03 21:49:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a7cbe8ba8fa0d622586f549a97c73d9b52efbea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698