Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2674573003: Update closure conversion test suite after changes to Target (Closed)

Created:
3 years, 10 months ago by asgerf
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update closure conversion test suite after changes to Target BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/6108988ba21d24b3066ea3f72b334b2f356778a4

Patch Set 1 #

Patch Set 2 : Remove inadvertent change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/kernel/test/closures/suite.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 10 months ago (2017-02-02 13:23:50 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 10 months ago (2017-02-02 13:28:44 UTC) #3
asgerf
3 years, 10 months ago (2017-02-02 13:30:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6108988ba21d24b3066ea3f72b334b2f356778a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698