editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java - Issue 26745004: Implement type variable 'more specific than' and 'subtype'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java

Issue 26745004: Implement type variable 'more specific than' and 'subtype'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java ('K') | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/TypeParameterTypeImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java

index 7f07d19c8494c7bb3f39c5afff9b1e91b437c4f2..39601a07077f6e62adc05033b5bffad6def225ab 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/type/InterfaceTypeImplTest.java

@@ -1113,11 +1113,13 @@ public class InterfaceTypeImplTest extends EngineTestCase {

}

public void test_isSubtypeOf_typeArguments() {

+ Type dynamicType = DynamicTypeImpl.getInstance();

ClassElement classA = classElement("A", "E");

ClassElement classI = classElement("I");

ClassElement classJ = classElement("J", classI.getType());

ClassElement classK = classElement("K");

InterfaceType typeA = classA.getType();

+ InterfaceType typeA_dynamic = typeA.substitute(new Type[] {dynamicType});

InterfaceTypeImpl typeAI = new InterfaceTypeImpl(classA);

InterfaceTypeImpl typeAJ = new InterfaceTypeImpl(classA);

InterfaceTypeImpl typeAK = new InterfaceTypeImpl(classA);

@@ -1133,12 +1135,12 @@ public class InterfaceTypeImplTest extends EngineTestCase {

assertTrue(typeAI.isSubtypeOf(typeAI));

// A <: A<I> and A <: A<J>

- assertTrue(typeA.isSubtypeOf(typeAI));

- assertTrue(typeA.isSubtypeOf(typeAJ));

+ assertTrue(typeA_dynamic.isSubtypeOf(typeAI));

+ assertTrue(typeA_dynamic.isSubtypeOf(typeAJ));

// A<I> <: A and A<J> <: A

- assertTrue(typeAI.isSubtypeOf(typeA));

- assertTrue(typeAJ.isSubtypeOf(typeA));

+ assertTrue(typeAI.isSubtypeOf(typeA_dynamic));

+ assertTrue(typeAJ.isSubtypeOf(typeA_dynamic));

// A<I> !<: A<K> and A<K> !<: A<I>

assertFalse(typeAI.isSubtypeOf(typeAK));