Issue 2674463002: Add fasta subdirectories to subpackage_relationships_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674463002: Add fasta subdirectories to subpackage_relationships_test. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add fasta subdirectories to subpackage_relationships_test. I populated subpackageRules with the set of dependencies that are needed in order to make the tests pass. Hopefully we can eliminate some of these dependencies in the future. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/ee78e6c3b3a3d711ac776dc7b5fc560831035bb6

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -10 lines)			Patch
	M	pkg/front_end/test/subpackage_relationships_test.dart	View		4 chunks	+103 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

ahe

lgtm Thank you, Paul! This is awesome. Yes, the dependencies are a bit verbose, but ...

3 years, 10 months ago (2017-02-02 07:47:39 UTC) #3

Paul Berry

3 years, 10 months ago (2017-02-02 11:01:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee78e6c3b3a3d711ac776dc7b5fc560831035bb6 (presubmit successful).