Issue 26744002: SkDocument api changes (abort, close return success, ...) modified: include/core/SkDocument.h m…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26744002: SkDocument api changes (abort, close return success, ...) modified: include/core/SkDocument.h m… (Closed)

Created:
7 years, 2 months ago by edisonn

Modified:
7 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, vandebo (ex-Chrome)

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

SkDocument api changes (abort, close return success, set DCT encoder...). R=reed Committed: http://code.google.com/p/skia/source/detail?r=11688

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -19 lines)			Patch
M	include/core/SkDocument.h	View	1 2	5 chunks	+20 lines, -4 lines	0 comments	Download
M	src/doc/SkDocument.cpp	View	1	2 chunks	+10 lines, -5 lines	0 comments	Download
M	src/doc/SkDocument_PDF.cpp	View	1 2 3	3 chunks	+23 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

reed1

lgtm should followup with some new unittests to exercise the new options in a later ...

7 years, 2 months ago (2013-10-09 20:01:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/26744002/7001

7 years, 2 months ago (2013-10-09 20:59:58 UTC) #3

Message was sent while issue was closed.

Change committed as 11688