Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2674353003: Enable WebViewAccessiblityTest for OOPIF webview. (Closed)
Patch Set: Fix typos. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <set> 6 #include <set>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 854 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool()); 865 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSizeTest, testing::Bool());
866 866
867 class WebViewVisibilityTest : public WebViewTest {}; 867 class WebViewVisibilityTest : public WebViewTest {};
868 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool()); 868 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewVisibilityTest, testing::Bool());
869 869
870 class WebViewSpeechAPITest : public WebViewTest {}; 870 class WebViewSpeechAPITest : public WebViewTest {};
871 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool()); 871 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewSpeechAPITest, testing::Bool());
872 872
873 // The following test suites are created to group tests based on specific 873 // The following test suites are created to group tests based on specific
874 // features of <webview>. 874 // features of <webview>.
875 // These features currently would not work with
876 // --enable-features=GuestViewCrossProcessFrames and is disabled on
877 // GuestViewCrossProcessFrames.
878 // TODO(avallee): https://crbug.com/610795: Enable this for testing::Bool().
879 class WebViewAccessibilityTest : public WebViewTest {}; 875 class WebViewAccessibilityTest : public WebViewTest {};
880 INSTANTIATE_TEST_CASE_P(WebViewTests, 876 INSTANTIATE_TEST_CASE_P(WebViewTests,
881 WebViewAccessibilityTest, 877 WebViewAccessibilityTest,
882 testing::Values(false)); 878 testing::Bool());
883
884 879
885 class WebViewDPITest : public WebViewTest { 880 class WebViewDPITest : public WebViewTest {
886 protected: 881 protected:
887 void SetUpCommandLine(base::CommandLine* command_line) override { 882 void SetUpCommandLine(base::CommandLine* command_line) override {
888 WebViewTest::SetUpCommandLine(command_line); 883 WebViewTest::SetUpCommandLine(command_line);
889 command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor, 884 command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor,
890 base::StringPrintf("%f", scale())); 885 base::StringPrintf("%f", scale()));
891 } 886 }
892 887
893 static float scale() { return 2.0f; } 888 static float scale() { return 2.0f; }
(...skipping 3291 matching lines...) Expand 10 before | Expand all | Expand 10 after
4185 ClosingChromeSignInShouldNotCrash) { 4180 ClosingChromeSignInShouldNotCrash) {
4186 GURL signin_url{"chrome://chrome-signin"}; 4181 GURL signin_url{"chrome://chrome-signin"};
4187 4182
4188 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED); 4183 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
4189 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED); 4184 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
4190 WaitForWebViewInDom(); 4185 WaitForWebViewInDom();
4191 4186
4192 chrome::CloseTab(browser()); 4187 chrome::CloseTab(browser());
4193 } 4188 }
4194 #endif 4189 #endif
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698