Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2674353003: Enable WebViewAccessiblityTest for OOPIF webview. (Closed)
Patch Set: Accessiblity tree will search for inner web contents. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <set> 6 #include <set>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 869 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 880
881 // The following test suites are created to group tests based on specific 881 // The following test suites are created to group tests based on specific
882 // features of <webview>. 882 // features of <webview>.
883 // These features currently would not work with 883 // These features currently would not work with
884 // --enable-features=GuestViewCrossProcessFrames and is disabled on 884 // --enable-features=GuestViewCrossProcessFrames and is disabled on
885 // GuestViewCrossProcessFrames. 885 // GuestViewCrossProcessFrames.
886 // TODO(avallee): https://crbug.com/610795: Enable this for testing::Bool(). 886 // TODO(avallee): https://crbug.com/610795: Enable this for testing::Bool().
887 class WebViewAccessibilityTest : public WebViewTest {}; 887 class WebViewAccessibilityTest : public WebViewTest {};
888 INSTANTIATE_TEST_CASE_P(WebViewTests, 888 INSTANTIATE_TEST_CASE_P(WebViewTests,
889 WebViewAccessibilityTest, 889 WebViewAccessibilityTest,
890 testing::Values(false)); 890 testing::Bool());
dmazzoni 2017/02/16 00:19:01 Yay! I think you can update the change descriptio
avallee 2017/02/21 20:00:31 Done.
891
892 891
893 class WebViewDPITest : public WebViewTest { 892 class WebViewDPITest : public WebViewTest {
894 protected: 893 protected:
895 void SetUpCommandLine(base::CommandLine* command_line) override { 894 void SetUpCommandLine(base::CommandLine* command_line) override {
896 WebViewTest::SetUpCommandLine(command_line); 895 WebViewTest::SetUpCommandLine(command_line);
897 command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor, 896 command_line->AppendSwitchASCII(switches::kForceDeviceScaleFactor,
898 base::StringPrintf("%f", scale())); 897 base::StringPrintf("%f", scale()));
899 } 898 }
900 899
901 static float scale() { return 2.0f; } 900 static float scale() { return 2.0f; }
(...skipping 2988 matching lines...) Expand 10 before | Expand all | Expand 10 after
3890 ClosingChromeSignInShouldNotCrash) { 3889 ClosingChromeSignInShouldNotCrash) {
3891 GURL signin_url{"chrome://chrome-signin"}; 3890 GURL signin_url{"chrome://chrome-signin"};
3892 3891
3893 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED); 3892 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
3894 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED); 3893 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
3895 WaitForWebViewInDom(); 3894 WaitForWebViewInDom();
3896 3895
3897 chrome::CloseTab(browser()); 3896 chrome::CloseTab(browser());
3898 } 3897 }
3899 #endif 3898 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698