Issue 2674353002: Modify fasta scanner testing logic to use ErrorToken.errorCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674353002: Modify fasta scanner testing logic to use ErrorToken.errorCode. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Modify fasta scanner testing logic to use ErrorToken.errorCode. Fixes 6 failing tests. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/e29f83feeb73696e78f6a8feacb8a0bc93131f93

Patch Set 2 : Make use of scanner.hasErrors #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -64 lines)			Patch
	M	pkg/front_end/test/scanner_test.dart	View	1	8 chunks	+50 lines, -64 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

lgtm https://codereview.chromium.org/2674353002/diff/20001/pkg/front_end/test/scanner_test.dart File pkg/front_end/test/scanner_test.dart (right): https://codereview.chromium.org/2674353002/diff/20001/pkg/front_end/test/scanner_test.dart#newcode414 pkg/front_end/test/scanner_test.dart:414: var errorCode = token.errorCode; Nice. I don't have ...

3 years, 10 months ago (2017-02-07 09:37:50 UTC) #3

Paul Berry

3 years, 10 months ago (2017-02-07 14:36:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e29f83feeb73696e78f6a8feacb8a0bc93131f93 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2674353002: Modify fasta scanner testing logic to use ErrorToken.errorCode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make use of scanner.hasErrors #

Messages