Provide IPConfigs in networkingPrivate.GetProperties

chromeos/network/shill_property_handler.h

Index: chromeos/network/shill_property_handler.h
diff --git a/chromeos/network/shill_property_handler.h b/chromeos/network/shill_property_handler.h
index e484e9801e425e9e268e0d1a45377f9c384d689e..ea582beb682caf3009fbb32a1619fad54995e134 100644
--- a/chromeos/network/shill_property_handler.h
+++ b/chromeos/network/shill_property_handler.h
@@ -71,6 +71,13 @@ class CHROMEOS_EXPORT ShillPropertyHandler
         const std::string& key,
         const base::Value& value) = 0;
 
+    // Called when a watched network or device IPConfig property changes.
+    virtual void UpdateIPConfigProperites(

[pneubeck (no reviews), 2014/05/05 21:09:28]

typo: Properites -> Properties (also in all implementations)

[stevenjb, 2014/05/06 01:15:11]

Done.

+        ManagedState::ManagedType type,
+        const std::string& path,
+        const std::string& ip_config_path,
+        const base::DictionaryValue& properties) = 0;
+
     // Called when the list of devices with portal check enabled changes.
     virtual void CheckPortalListChanged(
          const std::string& check_portal_list) = 0;
@@ -187,23 +194,25 @@ class CHROMEOS_EXPORT ShillPropertyHandler
                                const std::string& path,
                                const std::string& key,
                                const base::Value& value);
-  void NetworkServicePropertyChangedCallback(const std::string& path,
-                                             const std::string& key,
-                                             const base::Value& value);
 
-  // Callback for getting the IPConfig property of a Network. Handled here
-  // instead of in NetworkState so that all asynchronous requests are done
+  // Request a single IPConfig property from Shill.IPConfigClient.
+  void RequestIPConfig(ManagedState::ManagedType type,

[pneubeck (no reviews), 2014/05/05 21:09:28]

please document the arguments

[stevenjb, 2014/05/06 01:15:11]

Done.

+                       const std::string& path,
+                       const base::Value& value);
+
+  // Request a list IPConfig properties from Shill.IPConfigClient.

[pneubeck (no reviews), 2014/05/05 21:09:28]

'list of'

again, please document arguemnts

[stevenjb, 2014/05/06 01:15:11]

Done.

+  void RequestIPConfigsList(ManagedState::ManagedType type,
+                            const std::string& path,
+                            const base::Value& value);
+
+  // Callback for getting the IPConfig property of a network or device. Handled
+  // here instead of in NetworkState so that all asynchronous requests are done
   // in a single place (also simplifies NetworkState considerably).
-  void GetIPConfigCallback(const std::string& service_path,
+  void GetIPConfigCallback(ManagedState::ManagedType type,
+                           const std::string& path,
+                           const std::string& ip_config_path,
                            DBusMethodCallStatus call_status,
                            const base::DictionaryValue& properties);
-  void UpdateIPConfigProperty(const std::string& service_path,
-                              const base::DictionaryValue& properties,
-                              const char* property);
-
-  void NetworkDevicePropertyChangedCallback(const std::string& path,
-                                            const std::string& key,
-                                            const base::Value& value);
 
   // Pointer to containing class (owns this)
   Listener* listener_;