chromeos/network/onc/onc_translation_tables.cc - Issue 267433005: Provide IPConfigs in networkingPrivate.GetProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 267433005: Provide IPConfigs in networkingPrivate.GetProperties (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + Elim DHCP ONC types Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translation_tables.cc

diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc

index c520cf9be59693cd439aca067914940a9c503d58..a19419e0fecdbe18ad4f3506ca1e8987169d6a89 100644

--- a/chromeos/network/onc/onc_translation_tables.cc

+++ b/chromeos/network/onc/onc_translation_tables.cc

@@ -178,6 +178,9 @@ const FieldTranslationEntry ipconfig_fields[] = {

{ ::onc::ipconfig::kGateway, shill::kGatewayProperty},

{ ::onc::ipconfig::kRoutingPrefix, shill::kPrefixlenProperty},

{ ::onc::ipconfig::kNameServers, shill::kNameServersProperty},

+ // This field is converted during translation, see ShillToONCTranslator::

+ // TranslateIPConfig It is only converted from Shill->ONC.

pneubeck (no reviews) 2014/05/05 21:09:28 nit: 'IPConfig It' -> 'IPConfig. It' (missing dot

stevenjb 2014/05/06 01:15:11 Done.

+ // { ::onc::ipconfig::kType, shill::kMethodProperty},

{NULL}};

struct OncValueTranslationEntry {