Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chromeos/network/network_configuration_handler.h

Issue 267433005: Provide IPConfigs in networkingPrivate.GetProperties (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + Elim DHCP ONC types Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler.h
diff --git a/chromeos/network/network_configuration_handler.h b/chromeos/network/network_configuration_handler.h
index 3dc4a68ad5dfb463c3580676b5f5524c202a9e83..d24aeeb4ad6337cc90760446c7e5e5bafa516aae 100644
--- a/chromeos/network/network_configuration_handler.h
+++ b/chromeos/network/network_configuration_handler.h
@@ -59,7 +59,7 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
void GetProperties(
const std::string& service_path,
const network_handler::DictionaryResultCallback& callback,
- const network_handler::ErrorCallback& error_callback) const;
+ const network_handler::ErrorCallback& error_callback);
// Sets the properties of the network with id |service_path|. This means the
// given properties will be merged with the existing settings, and it won't
@@ -132,6 +132,15 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler
return profile_entry_deleters_.count(service_path);
}
+ // Copy the properties, fix Name, and add IPConfig properties, then invoke
+ // |callback| on success or |error_callback| on failure.
+ void GetPropertiesCallback(
+ const network_handler::DictionaryResultCallback& callback,
+ const network_handler::ErrorCallback& error_callback,
+ const std::string& service_path,
+ DBusMethodCallStatus call_status,
+ const base::DictionaryValue& properties);
+
// Invoke the callback and inform NetworkStateHandler to request an update
// for the service after setting properties.
void SetPropertiesSuccessCallback(const std::string& service_path,

Powered by Google App Engine
This is Rietveld 408576698