Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/GifTest.cpp

Issue 26743002: GIF decode: optional error messages and fault tolerance. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: whitespace lint changes Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/images/SkImageDecoder_libgif.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/GifTest.cpp
diff --git a/tests/GifTest.cpp b/tests/GifTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..4ec851df86b368c2e70c7f28f123cf1ac3b13234
--- /dev/null
+++ b/tests/GifTest.cpp
@@ -0,0 +1,201 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "SkBitmap.h"
+#include "SkData.h"
+#include "SkForceLinking.h"
+#include "SkImageDecoder.h"
+#include "SkImage.h"
+#include "SkStream.h"
+#include "Test.h"
+
+__SK_FORCE_IMAGE_DECODER_LINKING;
+
+namespace {
+ unsigned char gifData[] = {
+ 0x47, 0x49, 0x46, 0x38, 0x37, 0x61, 0x03, 0x00,
+ 0x03, 0x00, 0xe3, 0x08, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0xff, 0xff, 0x00, 0x00, 0xff, 0x00,
+ 0xff, 0x80, 0x80, 0x80, 0x00, 0xff, 0x00, 0x00,
+ 0xff, 0xff, 0xff, 0xff, 0x00, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0x2c, 0x00, 0x00,
+ 0x00, 0x00, 0x03, 0x00, 0x03, 0x00, 0x00, 0x04,
+ 0x07, 0x50, 0x1c, 0x43, 0x40, 0x41, 0x23, 0x44,
+ 0x00, 0x3b};
+ unsigned char gifDataNoColormap[] = {
+ 0x47, 0x49, 0x46, 0x38, 0x39, 0x61, 0x01, 0x00,
+ 0x01, 0x00, 0x00, 0x00, 0x00, 0x21, 0xf9, 0x04,
+ 0x01, 0x0a, 0x00, 0x01, 0x00, 0x2c, 0x00, 0x00,
+ 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x00, 0x02,
+ 0x02, 0x4c, 0x01, 0x00, 0x3b};
+ unsigned char interlacedGif[] = {
+ 0x47, 0x49, 0x46, 0x38, 0x37, 0x61, 0x09, 0x00,
+ 0x09, 0x00, 0xe3, 0x08, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0xff, 0xff, 0x00, 0x00, 0xff, 0x00,
+ 0xff, 0x80, 0x80, 0x80, 0x00, 0xff, 0x00, 0x00,
+ 0xff, 0xff, 0xff, 0xff, 0x00, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+ 0xff, 0xff, 0xff, 0xff, 0xff, 0x2c, 0x00, 0x00,
+ 0x00, 0x00, 0x09, 0x00, 0x09, 0x00, 0x40, 0x04,
+ 0x1b, 0x50, 0x1c, 0x23, 0xe9, 0x44, 0x23, 0x60,
+ 0x9d, 0x09, 0x28, 0x1e, 0xf8, 0x6d, 0x64, 0x56,
+ 0x9d, 0x53, 0xa8, 0x7e, 0xa8, 0x65, 0x94, 0x5c,
+ 0xb0, 0x8a, 0x45, 0x04, 0x00, 0x3b};
+}; // namespace
+
+static void testGifDataNoColormap(skiatest::Reporter* r,
scroggo 2013/10/10 20:02:12 nit: Typically we write our static functions with
+ void* data, size_t size) {
+ SkBitmap bm;
+ bool imageDecodeSuccess = SkImageDecoder::DecodeMemory(
+ data, size, &bm);
+ REPORTER_ASSERT(r, imageDecodeSuccess);
+ REPORTER_ASSERT(r, bm.width() == 1);
+ REPORTER_ASSERT(r, bm.height() == 1);
+ REPORTER_ASSERT(r, !(bm.empty()));
+ if (!(bm.empty())) {
+ REPORTER_ASSERT(r, bm.getColor(0, 0) == 0x00000000);
+ }
+}
+static void testGifData(skiatest::Reporter* r, void* data, size_t size) {
+ SkBitmap bm;
+ bool imageDecodeSuccess = SkImageDecoder::DecodeMemory(
+ data, size, &bm);
+ REPORTER_ASSERT(r, imageDecodeSuccess);
+ REPORTER_ASSERT(r, bm.width() == 3);
+ REPORTER_ASSERT(r, bm.height() == 3);
+ REPORTER_ASSERT(r, !(bm.empty()));
+ if (!(bm.empty())) {
+ REPORTER_ASSERT(r, bm.getColor(0, 0) == 0xffff0000);
+ REPORTER_ASSERT(r, bm.getColor(1, 0) == 0xffffff00);
+ REPORTER_ASSERT(r, bm.getColor(2, 0) == 0xff00ffff);
+ REPORTER_ASSERT(r, bm.getColor(0, 1) == 0xff808080);
+ REPORTER_ASSERT(r, bm.getColor(1, 1) == 0xff000000);
+ REPORTER_ASSERT(r, bm.getColor(2, 1) == 0xff00ff00);
+ REPORTER_ASSERT(r, bm.getColor(0, 2) == 0xffffffff);
+ REPORTER_ASSERT(r, bm.getColor(1, 2) == 0xffff00ff);
+ REPORTER_ASSERT(r, bm.getColor(2, 2) == 0xff0000ff);
+ }
+}
+static void testInterlacedGifData(skiatest::Reporter* r,
+ void* data,
+ size_t size) {
+ SkBitmap bm;
+ bool imageDecodeSuccess = SkImageDecoder::DecodeMemory(
+ data, size, &bm);
+ REPORTER_ASSERT(r, imageDecodeSuccess);
+ REPORTER_ASSERT(r, bm.width() == 9);
+ REPORTER_ASSERT(r, bm.height() == 9);
+ REPORTER_ASSERT(r, !(bm.empty()));
+ if (!(bm.empty())) {
+ REPORTER_ASSERT(r, bm.getColor(0, 0) == 0xffff0000);
+ REPORTER_ASSERT(r, bm.getColor(1, 0) == 0xffffff00);
+ REPORTER_ASSERT(r, bm.getColor(2, 0) == 0xff00ffff);
+
+ REPORTER_ASSERT(r, bm.getColor(0, 2) == 0xffffffff);
+ REPORTER_ASSERT(r, bm.getColor(1, 2) == 0xffff00ff);
+ REPORTER_ASSERT(r, bm.getColor(2, 2) == 0xff0000ff);
+
+ REPORTER_ASSERT(r, bm.getColor(0, 4) == 0xff808080);
+ REPORTER_ASSERT(r, bm.getColor(1, 4) == 0xff000000);
+ REPORTER_ASSERT(r, bm.getColor(2, 4) == 0xff00ff00);
+
+ REPORTER_ASSERT(r, bm.getColor(0, 6) == 0xffff0000);
+ REPORTER_ASSERT(r, bm.getColor(1, 6) == 0xffffff00);
+ REPORTER_ASSERT(r, bm.getColor(2, 6) == 0xff00ffff);
+
+ REPORTER_ASSERT(r, bm.getColor(0, 8) == 0xffffffff);
+ REPORTER_ASSERT(r, bm.getColor(1, 8) == 0xffff00ff);
+ REPORTER_ASSERT(r, bm.getColor(2, 8) == 0xff0000ff);
+ }
+}
+
+static void testGifDataShort(skiatest::Reporter* r, void* data, size_t size) {
+ SkBitmap bm;
+ bool imageDecodeSuccess = SkImageDecoder::DecodeMemory(
+ data, size, &bm);
+ REPORTER_ASSERT(r, imageDecodeSuccess);
+ REPORTER_ASSERT(r, bm.width() == 3);
+ REPORTER_ASSERT(r, bm.height() == 3);
+ REPORTER_ASSERT(r, !(bm.empty()));
+ if (!(bm.empty())) {
+ REPORTER_ASSERT(r, bm.getColor(0, 0) == 0xffff0000);
+ REPORTER_ASSERT(r, bm.getColor(1, 0) == 0xffffff00);
+ REPORTER_ASSERT(r, bm.getColor(2, 0) == 0xff00ffff);
+ REPORTER_ASSERT(r, bm.getColor(0, 1) == 0xff808080);
+ REPORTER_ASSERT(r, bm.getColor(1, 1) == 0xff000000);
+ REPORTER_ASSERT(r, bm.getColor(2, 1) == 0xff00ff00);
+ }
+}
+
+/**
+ This test will test the ability of the SkImageDecoder to deal with
+ GIF files which have been mangled somehow. We want to display as
+ much of the GIF as possible.
+*/
+static void TestGif(skiatest::Reporter* reporter) {
+ // test perfectly good images.
+ testGifData(reporter, static_cast<void *>(gifData), sizeof(gifData));
+ testInterlacedGifData(reporter, static_cast<void *>(interlacedGif),
+ sizeof(interlacedGif));
+
+ unsigned char badData[sizeof(gifData)];
+
+ /* If you set the environment variable
+ skia_images_gif_suppressDecoderWarnings to 'false', you will
+ see warnings on stderr. This is a feature. */
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[6] = 0x01; // image too wide
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [image too wide, expanding output to size]"
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[8] = 0x01; // image too tall
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [image too tall, expanding output to size]"
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[62] = 0x01; // image shifted right
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [shifting image left to fit]"
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[64] = 0x01; // image shifted down
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [shifting image up to fit]"
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[62] = 0xff; // image shifted left
+ badData[63] = 0xff; // 2's complement -1 short
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [shifting image left to fit]"
+
+ memcpy(badData, gifData, sizeof(gifData));
+ badData[64] = 0xff; // image shifted up
+ badData[65] = 0xff; // 2's complement -1 short
+ testGifData(reporter, static_cast<void *>(badData), sizeof(gifData));
+ // "libgif warning [shifting image up to fit]"
+
+ testGifDataNoColormap(reporter, static_cast<void *>(gifDataNoColormap),
+ sizeof(gifDataNoColormap));
+ // "libgif warning [missing colormap]"
+
+ // test short Gif. 80 is missing a few bytes.
+ testGifDataShort(reporter, static_cast<void *>(gifData), 80);
+ // "libgif warning [DGifGetLine]"
+
+ testInterlacedGifData(reporter, static_cast<void *>(interlacedGif),
+ 100); // 100 is missing a few bytes
+ // "libgif warning [interlace DGifGetLine]"
+}
+
+#include "TestClassDef.h"
+DEFINE_TESTCLASS("GifTest", GifTestClass, TestGif)
+
« no previous file with comments | « src/images/SkImageDecoder_libgif.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698