Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2674253004: [refactor] Remove WebWidget::applyReplacementRange (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 0add5cabb94db1c4dfe3eeb821c5a934d742d889..e0806264bfa5399db8eb98fe12934fd233bb3047 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -696,16 +696,6 @@ bool WebFrameWidgetImpl::getCompositionCharacterBounds(
return true;
}
-// TODO(ekaramad):This method is almost duplicated in WebViewImpl as well. This
-// code needs to be refactored (http://crbug.com/629721).
-void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range) {
- if (LocalFrame* frame = focusedLocalFrameInWidget()) {
- // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
- // silly. What is going on here?
- WebLocalFrameImpl::fromFrame(frame)->selectRange(range);
- }
-}
-
void WebFrameWidgetImpl::setRemoteViewportIntersection(
const WebRect& viewportIntersection) {
// Remote viewports are only applicable to local frames with remote ancestors.
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/Source/web/WebInputMethodControllerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698