[refactor] Remove WebWidget::applyReplacementRange

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 652 matching lines @@
 
   return RenderThread::Get()->Send(message);
 }
 
 void RenderWidget::SendOrCrash(IPC::Message* message) {
   bool result = Send(message);
   CHECK(closing_ || result) << "Failed to send message";
 }
 
 bool RenderWidget::ShouldHandleImeEvents() const {
-  return GetWebWidget()->isWebFrameWidget() && has_focus_;
+  return GetWebWidget() && GetWebWidget()->isWebFrameWidget() && has_focus_;
 }
 
 void RenderWidget::SetWindowRectSynchronously(
     const gfx::Rect& new_window_rect) {
   ResizeParams params;
   params.screen_info = screen_info_;
   params.new_size = new_window_rect.size();
   params.physical_backing_size =
       gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_);
   params.visible_viewport_size = new_window_rect.size();
@@ skipping 879 matching lines @@
   if (!ShouldHandleImeEvents())
     return;
 
 #if BUILDFLAG(ENABLE_PLUGINS)
   if (focused_pepper_plugin_) {
     focused_pepper_plugin_->render_frame()->OnImeSetComposition(
         text, underlines, selection_start, selection_end);
     return;
   }
 #endif
-  if (replacement_range.IsValid()) {
-    GetWebWidget()->applyReplacementRange(
-        WebRange(replacement_range.start(), replacement_range.length()));
-  }
-
-  if (!GetWebWidget())
-    return;
   ImeEventGuard guard(this);
   blink::WebInputMethodController* controller = GetInputMethodController();
   if (!controller ||
       !controller->setComposition(
           WebString::fromUTF16(text),
-          WebVector<WebCompositionUnderline>(underlines), selection_start,
-          selection_end)) {
+          WebVector<WebCompositionUnderline>(underlines),
+          replacement_range.IsValid()
+              ? WebRange(replacement_range.start(), replacement_range.length())
+              : WebRange(),
+          selection_start, selection_end)) {
     // If we failed to set the composition text, then we need to let the browser
     // process to cancel the input method's ongoing composition session, to make
     // sure we are in a consistent state.
     Send(new InputHostMsg_ImeCancelComposition(routing_id()));
   }
   UpdateCompositionInfo(false /* not an immediate request */);
 }
 
 void RenderWidget::OnImeCommitText(
     const base::string16& text,
     const std::vector<WebCompositionUnderline>& underlines,
     const gfx::Range& replacement_range,
     int relative_cursor_pos) {
   if (!ShouldHandleImeEvents())
     return;
 
 #if BUILDFLAG(ENABLE_PLUGINS)
   if (focused_pepper_plugin_) {
     focused_pepper_plugin_->render_frame()->OnImeCommitText(
         text, replacement_range, relative_cursor_pos);
     return;
   }
 #endif
-  if (replacement_range.IsValid()) {
-    GetWebWidget()->applyReplacementRange(
-        WebRange(replacement_range.start(), replacement_range.length()));
-  }
-
-  if (!GetWebWidget())
-    return;
   ImeEventGuard guard(this);
   input_handler_->set_handling_input_event(true);
   if (auto* controller = GetInputMethodController())
-    controller->commitText(WebString::fromUTF16(text),
-                           WebVector<WebCompositionUnderline>(underlines),
-                           relative_cursor_pos);
+    controller->commitText(
+        WebString::fromUTF16(text),
+        WebVector<WebCompositionUnderline>(underlines),
+        replacement_range.IsValid()
+            ? WebRange(replacement_range.start(), replacement_range.length())
+            : WebRange(),
+        relative_cursor_pos);
   input_handler_->set_handling_input_event(false);
   UpdateCompositionInfo(false /* not an immediate request */);
 }
 
 void RenderWidget::OnImeFinishComposingText(bool keep_selection) {
   if (!ShouldHandleImeEvents())
     return;
 
 #if BUILDFLAG(ENABLE_PLUGINS)
   if (focused_pepper_plugin_) {
@@ skipping 676 matching lines @@
     // browser side (https://crbug.com/669219).
     // If there is no WebFrameWidget, then there will be no
     // InputMethodControllers for a WebLocalFrame.
     return nullptr;
   }
   return static_cast<blink::WebFrameWidget*>(GetWebWidget())
       ->getActiveWebInputMethodController();
 }
 
 }  // namespace content