Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2674243004: DevTools: restore the style of expandable titles on console object previews (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 if (includePreview && obj.preview) { 527 if (includePreview && obj.preview) {
528 titleElement.classList.add('console-object-preview'); 528 titleElement.classList.add('console-object-preview');
529 this._previewFormatter.appendObjectPreview(titleElement, obj.preview); 529 this._previewFormatter.appendObjectPreview(titleElement, obj.preview);
530 } else if (obj.type === 'function') { 530 } else if (obj.type === 'function') {
531 Components.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElemen t, false); 531 Components.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElemen t, false);
532 titleElement.classList.add('object-value-function'); 532 titleElement.classList.add('object-value-function');
533 } else { 533 } else {
534 titleElement.createTextChild(obj.description || ''); 534 titleElement.createTextChild(obj.description || '');
535 } 535 }
536 536
537 var note = titleElement.createChild('span', 'object-state-note');
538 note.classList.add('info-note');
539 note.title = Common.UIString('Value below was evaluated just now.');
540
537 var section = new Components.ObjectPropertiesSection(obj, titleElement, this ._linkifier); 541 var section = new Components.ObjectPropertiesSection(obj, titleElement, this ._linkifier);
538 section.element.classList.add('console-view-object-properties-section'); 542 section.element.classList.add('console-view-object-properties-section');
539 section.enableContextMenu(); 543 section.enableContextMenu();
540 return section.element; 544 return section.element;
541 } 545 }
542 546
543 /** 547 /**
544 * @param {!SDK.RemoteObject} func 548 * @param {!SDK.RemoteObject} func
545 * @param {boolean=} includePreview 549 * @param {boolean=} includePreview
546 * @return {!Element} 550 * @return {!Element}
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
1201 toMessageElement() { 1205 toMessageElement() {
1202 if (!this._element) { 1206 if (!this._element) {
1203 super.toMessageElement(); 1207 super.toMessageElement();
1204 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon'); 1208 this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
1205 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild); 1209 this._contentElement.insertBefore(this._expandGroupIcon, this._contentElem ent.firstChild);
1206 this.setCollapsed(this._collapsed); 1210 this.setCollapsed(this._collapsed);
1207 } 1211 }
1208 return this._element; 1212 return this._element;
1209 } 1213 }
1210 }; 1214 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698