DevTools: restore the style of expandable titles on console object previews

third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 35 matching lines @@
         object, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperties);
     this.appendChild(this._objectTreeElement);
     if (typeof title === 'string' || !title) {
       this.titleElement = this.element.createChild('span');
       this.titleElement.textContent = title || '';
     } else {
       this.titleElement = title;
       this.element.appendChild(title);
     }
 
-    if (object.description && Components.ObjectPropertiesSection._needsAlternateTitle(object)) {
-      this.expandedTitleElement = createElement('span');
-      this.expandedTitleElement.createTextChild(object.description);
-
-      var note = this.expandedTitleElement.createChild('span', 'object-state-note');
-      note.classList.add('info-note');
-      note.title = Common.UIString('Value below was evaluated just now.');
-    }
-
     this.element._section = this;
     this.registerRequiredCSS('components/objectValue.css');
     this.registerRequiredCSS('components/objectPropertiesSection.css');
     this.rootElement().childrenListElement.classList.add('source-code', 'object-properties-section');
   }
 
   /**
    * @param {!SDK.RemoteObject} object
    * @param {!Components.Linkifier=} linkifier
    * @param {boolean=} skipProto
@@ skipping 245 matching lines @@
       var numberParts = description.split('e');
       valueElement.createChild('span', 'object-value-scientific-notation-mantissa').textContent = numberParts[0];
       valueElement.createChild('span', 'object-value-scientific-notation-exponent').textContent = 'e' + numberParts[1];
       valueElement.classList.add('object-value-scientific-notation-number');
       valueElement.title = description || '';
       return valueElement;
     }
   }
 
   /**
-   * @param {!SDK.RemoteObject} object
-   * @return {boolean}
-   */
-  static _needsAlternateTitle(object) {
-    return object && object.hasChildren && !object.customPreview() && object.subtype !== 'node' &&
-        object.type !== 'function' && (object.type !== 'object' || object.preview);
-  }
-
-  /**
    * @param {!SDK.RemoteObject} func
    * @param {!Element} element
    * @param {boolean} linkify
    * @param {boolean=} includePreview
    */
   static formatObjectAsFunction(func, element, linkify, includePreview) {
     func.debuggerModel().functionDetailsPromise(func).then(didGetDetails);
 
     /**
      * @param {?SDK.DebuggerModel.FunctionDetails} response
@@ skipping 81 matching lines @@
     this.selectable = false;
     this.toggleOnClick = true;
     this.listItemElement.classList.add('object-properties-section-root-element');
     this._linkifier = linkifier;
   }
 
   /**
    * @override
    */
   onexpand() {
-    if (this.treeOutline) {
+    if (this.treeOutline)
       this.treeOutline.element.classList.add('expanded');
-      this._showExpandedTitleElement(true);
-    }
   }
 
   /**
    * @override
    */
   oncollapse() {
-    if (this.treeOutline) {
+    if (this.treeOutline)
       this.treeOutline.element.classList.remove('expanded');
-      this._showExpandedTitleElement(false);
-    }
   }
 
   /**
-   * @param {boolean} value
-   */
-  _showExpandedTitleElement(value) {
-    if (!this.treeOutline.expandedTitleElement)
-      return;
-    if (value)
-      this.treeOutline.element.replaceChild(this.treeOutline.expandedTitleElement, this.treeOutline.titleElement);
-    else
-      this.treeOutline.element.replaceChild(this.treeOutline.titleElement, this.treeOutline.expandedTitleElement);
-  }
-
-  /**
    * @override
    * @param {!Event} e
    * @return {boolean}
    */
   ondblclick(e) {
     return true;
   }
 
   /**
    * @override
@@ skipping 271 matching lines @@
       this.listItemElement.replaceChild(this.expandedValueElement, this.valueElement);
     else
       this.listItemElement.replaceChild(this.valueElement, this.expandedValueElement);
   }
 
   /**
    * @param {!SDK.RemoteObject} value
    * @return {?Element}
    */
   _createExpandedValueElement(value) {
-    if (!Components.ObjectPropertiesSection._needsAlternateTitle(value))
+    var needsAlternateValue = value.hasChildren && !value.customPreview() && value.subtype !== 'node' &&
+        value.type !== 'function' && (value.type !== 'object' || value.preview);
+    if (!needsAlternateValue)
       return null;
 
     var valueElement = createElementWithClass('span', 'value');
     valueElement.setTextContentTruncatedIfNeeded(value.description || '');
     valueElement.classList.add('object-value-' + (value.subtype || value.type));
     valueElement.title = value.description || '';
     return valueElement;
   }
 
   update() {
@@ skipping 594 matching lines @@
     }
     var treeOutlineId = treeElement.treeOutline[Components.ObjectPropertiesSectionExpandController._treeOutlineId];
     result = treeOutlineId + (result ? ':' + result : '');
     treeElement[Components.ObjectPropertiesSectionExpandController._cachedPathSymbol] = result;
     return result;
   }
 };
 
 Components.ObjectPropertiesSectionExpandController._cachedPathSymbol = Symbol('cachedPath');
 Components.ObjectPropertiesSectionExpandController._treeOutlineId = Symbol('treeOutlineId');