Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 267423006: Add asADash to Lua for scraping (Closed)

Created:
6 years, 7 months ago by egdaniel
Modified:
6 years, 7 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add asADash to Lua for scraping BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14733

Patch Set 1 #

Patch Set 2 : add pushDash #

Total comments: 1

Patch Set 3 : Add intervals to dash #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M include/utils/SkLua.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/utils/SkLua.cpp View 1 2 3 5 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
egdaniel
ptal
6 years, 7 months ago (2014-05-14 13:08:49 UTC) #1
egdaniel
Added pushDash to match the structure used by other parts of code
6 years, 7 months ago (2014-05-14 13:38:37 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/267423006/diff/20001/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/267423006/diff/20001/src/utils/SkLua.cpp#newcode1017 src/utils/SkLua.cpp:1017: SkPathEffect* pe = get_ref<SkPathEffect>(L, 1); NULL != ?
6 years, 7 months ago (2014-05-14 14:01:34 UTC) #3
egdaniel
I've added the intervals to push Dash and removed the count (since in lua we ...
6 years, 7 months ago (2014-05-14 15:29:35 UTC) #4
robertphillips
lgtm + 1 nit https://codereview.chromium.org/267423006/diff/40001/src/utils/SkLua.cpp File src/utils/SkLua.cpp (right): https://codereview.chromium.org/267423006/diff/40001/src/utils/SkLua.cpp#newcode250 src/utils/SkLua.cpp:250: setfield_scalar(fL, "phase", info.fPhase); this->
6 years, 7 months ago (2014-05-14 15:36:18 UTC) #5
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 7 months ago (2014-05-14 15:37:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/267423006/40001
6 years, 7 months ago (2014-05-14 15:37:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 15:37:32 UTC) #8
commit-bot: I haz the power
Presubmit check for 267423006-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-05-14 15:37:32 UTC) #9
egdaniel
robs nit
6 years, 7 months ago (2014-05-14 15:40:41 UTC) #10
reed1
lgtm
6 years, 7 months ago (2014-05-14 15:41:14 UTC) #11
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 7 months ago (2014-05-14 15:41:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/267423006/60001
6 years, 7 months ago (2014-05-14 15:41:51 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 16:03:17 UTC) #14
Message was sent while issue was closed.
Change committed as 14733

Powered by Google App Engine
This is Rietveld 408576698