Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Issue 2674193003: [ObjC ARC] Converts ios/chrome/browser/ui/authentication:eg_tests to ARC. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/authentication/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
diff --git a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
index cd544f53a606612e5e66fcc5d7fbd24bddf6221f..0b2b45df78b5ed2736efdfbcadeafc258df4f56b 100644
--- a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
+++ b/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
@@ -27,6 +27,10 @@
#import "ios/testing/earl_grey/disabled_test_macros.h"
#import "ios/testing/wait_util.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
// Returns a fake identity.
@@ -406,8 +410,8 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
OpenSignInFromSettings();
// Open new tab to cancel sign-in.
- base::scoped_nsobject<OpenUrlCommand> command(
- [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")]);
+ OpenUrlCommand* command =
+ [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")];
chrome_test_util::RunCommandWithActiveViewController(command);
// Re-open the sign-in screen. If it wasn't correctly dismissed previously,
@@ -444,8 +448,8 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];
// Open new tab to cancel sign-in.
- base::scoped_nsobject<OpenUrlCommand> command(
- [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")]);
+ OpenUrlCommand* command =
+ [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")];
chrome_test_util::RunCommandWithActiveViewController(command);
// Re-open the sign-in screen. If it wasn't correctly dismissed previously,
@@ -503,8 +507,8 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
TapButtonWithLabelId(IDS_IOS_ACCOUNT_CONSISTENCY_SETUP_SIGNIN_BUTTON);
// Open new tab to cancel sign-in.
- base::scoped_nsobject<OpenUrlCommand> command(
- [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")]);
+ OpenUrlCommand* command =
+ [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")];
chrome_test_util::RunCommandWithActiveViewController(command);
// Re-open the sign-in screen. If it wasn't correctly dismissed previously,
@@ -564,8 +568,8 @@ void AssertAuthenticatedIdentityInActiveProfile(ChromeIdentity* identity) {
assertWithMatcher:grey_sufficientlyVisible()];
// Open new tab to cancel sign-in.
- base::scoped_nsobject<OpenUrlCommand> command(
- [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")]);
+ OpenUrlCommand* command =
+ [[OpenUrlCommand alloc] initWithURLFromChrome:GURL("about:blank")];
chrome_test_util::RunCommandWithActiveViewController(command);
// Re-open the sign-in screen. If it wasn't correctly dismissed previously,
« no previous file with comments | « ios/chrome/browser/ui/authentication/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698