third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2674173002: Fix undo stack ordering for all-but-typing commands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2674173002: Fix undo stack ordering for all-but-typing commands (Closed)

Patch Set: Minimize test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/undo/paste_with_mutation_event_undo_order.html ('K') | « third_party/WebKit/LayoutTests/editing/undo/paste_with_mutation_event_undo_order.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index aa29a5f5d9f0af0cf6133eba5bc4228a4f70234a..f7ec6faf53a26fdf16b22098462846bc1f04f465 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -127,10 +127,8 @@ bool CompositeEditCommand::apply() {

LocalFrame* frame = document().frame();

DCHECK(frame);

EditingState editingState;

- {

- EventQueueScope eventQueueScope;

- doApply(&editingState);

- }

+ EventQueueScope eventQueueScope;

+ doApply(&editingState);

// Only need to call appliedEditing for top-level commands, and TypingCommands

// do it on their own (see TypingCommand::typingAddedToOpenCommand).