Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3609)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 2674163002: Convert BrowserTest.NoStopDuringTransferUntilCommit to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 706b88bf61bbcb68a08b91b5b4e37ef225a6c223..bbb9340766ee96694c2b25e5248ab947cf06df38 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -721,14 +721,16 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) {
class RedirectObserver : public content::WebContentsObserver {
public:
explicit RedirectObserver(content::WebContents* web_contents)
- : WebContentsObserver(web_contents) {
+ : WebContentsObserver(web_contents),
+ transition_(ui::PageTransition::PAGE_TRANSITION_LINK) {
}
- void DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override {
- params_ = params;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override {
+ if (!navigation_handle->HasCommitted())
+ return;
+ transition_ = navigation_handle->GetPageTransition();
+ redirects_ = navigation_handle->GetRedirectChain();
}
void WebContentsDestroyed() override {
@@ -737,12 +739,12 @@ class RedirectObserver : public content::WebContentsObserver {
FAIL() << "WebContents closed during navigation (http://crbug.com/314036).";
}
- const content::FrameNavigateParams& params() const {
- return params_;
- }
+ ui::PageTransition transition() const { return transition_; }
+ const std::vector<GURL> redirects() const { return redirects_; }
private:
- content::FrameNavigateParams params_;
+ ui::PageTransition transition_;
+ std::vector<GURL> redirects_;
DISALLOW_COPY_AND_ASSIGN(RedirectObserver);
};
@@ -789,11 +791,11 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, NoStopDuringTransferUntilCommit) {
// history autocomplete to work.
EXPECT_EQ(redirect_url, contents->GetController().GetLastCommittedEntry()->
GetOriginalRequestURL());
- EXPECT_EQ(2U, redirect_observer.params().redirects.size());
- EXPECT_EQ(redirect_url, redirect_observer.params().redirects.at(0));
- EXPECT_EQ(dest_url, redirect_observer.params().redirects.at(1));
+ EXPECT_EQ(2U, redirect_observer.redirects().size());
+ EXPECT_EQ(redirect_url, redirect_observer.redirects().at(0));
+ EXPECT_EQ(dest_url, redirect_observer.redirects().at(1));
EXPECT_TRUE(ui::PageTransitionCoreTypeIs(
- redirect_observer.params().transition, ui::PAGE_TRANSITION_TYPED));
+ redirect_observer.transition(), ui::PAGE_TRANSITION_TYPED));
}
// Restore previous browser client.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698