Source/core/html/shadow/DateTimeFieldElement.h - Issue 267413002: Oilpan: Prepare to move UA shadow elemnts for date/time input types to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeFieldElement.h

Issue 267413002: Oilpan: Prepare to move UA shadow elemnts for date/time input types to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: nits Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/shadow/DateTimeEditElement.h ('K') | « Source/core/html/shadow/DateTimeEditElement.cpp ('k') | Source/core/html/shadow/DateTimeFieldElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/DateTimeFieldElement.h

diff --git a/Source/core/html/shadow/DateTimeFieldElement.h b/Source/core/html/shadow/DateTimeFieldElement.h

index ade59e0d7a401dd89aabb64637c90054ae639473..c62c9d673b80b3e5dd361a3474fe2b910b755989 100644

--- a/Source/core/html/shadow/DateTimeFieldElement.h

+++ b/Source/core/html/shadow/DateTimeFieldElement.h

@@ -48,7 +48,7 @@ public:

// FieldOwner implementer must call removeEventHandler when

// it doesn't handle event, e.g. at destruction.

- class FieldOwner {

+ class FieldOwner : public WillBeGarbageCollectedMixin {

public:

virtual ~FieldOwner();

virtual void didBlurFromField() = 0;

@@ -67,7 +67,7 @@ public:

bool isDisabled() const;

virtual float maximumWidth(const Font&);

virtual void populateDateTimeFieldsState(DateTimeFieldsState&) = 0;

- void removeEventHandler() { m_fieldOwner = 0; }

+ void removeEventHandler() { m_fieldOwner = nullptr; }

void setDisabled();

virtual void setEmptyValue(EventBehavior = DispatchNoEvent) = 0;

virtual void setValueAsDate(const DateComponents&) = 0;

@@ -77,6 +77,7 @@ public:

virtual void stepUp() = 0;

virtual String value() const = 0;

virtual String visibleValue() const = 0;

+ virtual void trace(Visitor*) OVERRIDE;

protected:

DateTimeFieldElement(Document&, FieldOwner&);

@@ -99,7 +100,7 @@ private:

bool isFieldOwnerReadOnly() const;

virtual bool supportsFocus() const OVERRIDE FINAL;

- FieldOwner* m_fieldOwner;

+ RawPtrWillBeWeakMember<FieldOwner> m_fieldOwner;

Mads Ager (chromium) 2014/05/07 14:55:08 Ditto for this one? It would be great if this coul

};

} // namespace WebCore