Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2674023002: Use function pointers in net/base/filename_util_internal.h instead of base::Bind (Closed)

Created:
3 years, 10 months ago by dcheng
Modified:
3 years, 10 months ago
Reviewers:
asanka, Jana
CC:
bnc+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, jshin+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use function pointers in net/base/filename_util_internal.h instead of base::Bind The internal helpers don't actually need to capture state, so using function pointers directly is more efficient. BUG=none Review-Url: https://codereview.chromium.org/2674023002 Cr-Commit-Position: refs/heads/master@{#448823} Committed: https://chromium.googlesource.com/chromium/src/+/5fa493d68730231fb936bd309c3d6814686135fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M net/base/filename_util_icu.cc View 3 chunks +5 lines, -16 lines 0 comments Download
M net/base/filename_util_internal.h View 5 chunks +6 lines, -8 lines 0 comments Download
M net/base/filename_util_internal.cc View 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dcheng
3 years, 10 months ago (2017-02-07 22:49:56 UTC) #6
asanka
lgtm
3 years, 10 months ago (2017-02-07 23:05:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674023002/1
3 years, 10 months ago (2017-02-07 23:12:29 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 00:54:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fa493d68730231fb936bd309c3d...

Powered by Google App Engine
This is Rietveld 408576698