Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2674002: Convert RTF on the pasteboard to HTML and all it to substitute if present and... (Closed)

Created:
10 years, 6 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Convert RTF on the pasteboard to HTML and all it to substitute if present and no HTML is on a paste or drop. Safari does not put HTML on the pasteboard, only RTF. BUG=44661 TEST=dropping/pasting html should retain basic structure, but fonts/colors don't seem to propagate. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48962

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M app/clipboard/clipboard_mac.mm View 1 4 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/web_drop_target.mm View 1 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/mozilla/NSPasteboard+Utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/mozilla/NSPasteboard+Utils.mm View 1 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/mozilla/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pink (ping after 24hrs)
10 years, 6 months ago (2010-06-04 17:02:04 UTC) #1
Robert Sesek
http://codereview.chromium.org/2674002/diff/1/2 File app/clipboard/clipboard_mac.mm (right): http://codereview.chromium.org/2674002/diff/1/2#newcode1 app/clipboard/clipboard_mac.mm:1: // Copyright (c) 2006-2008 The Chromium Authors. All rights ...
10 years, 6 months ago (2010-06-04 17:12:59 UTC) #2
pink (ping after 24hrs)
all issues addressed. take another look. http://codereview.chromium.org/2674002/diff/1/2 File app/clipboard/clipboard_mac.mm (right): http://codereview.chromium.org/2674002/diff/1/2#newcode1 app/clipboard/clipboard_mac.mm:1: // Copyright (c) ...
10 years, 6 months ago (2010-06-04 17:20:19 UTC) #3
Robert Sesek
10 years, 6 months ago (2010-06-04 17:23:49 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698