Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart

Issue 267393009: Transition barback's infrastructure to an aggregate-based model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/test/package_graph/transform/cross_package_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart b/sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart
index 7ebd55bfdba384520724c848975feabd2feb70f8..0d9a9651cca857dd2050cb84b2ea3f25dc5c207c 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/excluding_transformer.dart
@@ -37,16 +37,16 @@ class ExcludingTransformer extends Transformer {
ExcludingTransformer._(this._inner, this._includes, this._excludes);
- Future<bool> isPrimary(AssetId id) {
+ isPrimary(AssetId id) {
// TODO(rnystrom): Support globs in addition to paths. See #17093.
if (_includes != null) {
// If there are any includes, it must match one of them.
- if (!_includes.contains(id.path)) return new Future.value(false);
+ if (!_includes.contains(id.path)) return false;
}
// It must not be excluded.
if (_excludes != null && _excludes.contains(id.path)) {
- return new Future.value(false);
+ return false;
}
return _inner.isPrimary(id);
« no previous file with comments | « pkg/barback/test/package_graph/transform/cross_package_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698