Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: pkg/barback/lib/src/transformer/aggregate_transformer.dart

Issue 267393009: Transition barback's infrastructure to an aggregate-based model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/barback/lib/src/transformer/aggregate_transformer.dart
diff --git a/pkg/barback/lib/src/transformer/aggregate_transformer.dart b/pkg/barback/lib/src/transformer/aggregate_transformer.dart
index 959b3e75a105331b06982d154b0e83070e7b1da5..6873e990a5ab8398e142466588ee605d02651413 100644
--- a/pkg/barback/lib/src/transformer/aggregate_transformer.dart
+++ b/pkg/barback/lib/src/transformer/aggregate_transformer.dart
@@ -32,15 +32,14 @@ abstract class AggregateTransformer {
/// All assets for which [classifyPrimary] returns the same key are passed
/// together to the same [apply] call.
///
- /// Any string can be used to classify an asset. If possible, though, this
- /// should return a path-like string to aid in logging. If [classifyPrimary]
- /// needs to do asynchronous work, it can also return a [Future] that
- /// completes to the key.
+ /// This may return [Future<String>] or, if it's entirely synchronous,
+ /// [String]. Any string can be used to classify an asset. If possible,
+ /// though, this should return a path-like string to aid in logging.
///
/// A return value of `null` indicates that the transformer is not interested
/// in an asset. Assets with a key of `null` will not be passed to any [apply]
/// call; this is equivalent to [Transformer.isPrimary] returning `false`.
- String classifyPrimary(AssetId id);
+ classifyPrimary(AssetId id);
/// Runs this transformer on a group of primary inputs specified by
/// [transform].
« no previous file with comments | « pkg/barback/lib/src/transformer/aggregate_transform.dart ('k') | pkg/barback/lib/src/transformer/base_transform.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698