Chromium Code Reviews| Index: pkg/barback/lib/src/errors.dart |
| diff --git a/pkg/barback/lib/src/errors.dart b/pkg/barback/lib/src/errors.dart |
| index 290d534897d1e790a509072edb144fd4bb498ae1..0c2b5c5dd5e3eb33eceb424152b6665406607350 100644 |
| --- a/pkg/barback/lib/src/errors.dart |
| +++ b/pkg/barback/lib/src/errors.dart |
| @@ -7,7 +7,7 @@ library barback.errors; |
| import 'package:stack_trace/stack_trace.dart'; |
| import 'asset/asset_id.dart'; |
| -import 'transformer/transformer.dart'; |
| +import 'transformer/wrapping_aggregate_transformer.dart'; |
| import 'utils.dart'; |
| /// Error thrown when an asset with [id] cannot be found. |
| @@ -167,12 +167,17 @@ class AssetLoadException extends _WrappedException { |
| /// the transformer that is applied to it. |
| class TransformInfo { |
| /// The transformer that's run for this transform. |
| - final Transformer transformer; |
| + /// |
| + /// This may be a [Transformer] or a [WrappingAggregateTransformer]. It may |
| + /// also return additional types in the future. |
|
Bob Nystrom
2014/05/08 20:30:48
I know we talked about this a bit before but I don
nweiz
2014/05/08 21:12:36
I think it's useful for users to be able to reliab
Bob Nystrom
2014/05/08 23:56:13
Maybe, but I think we could support that with myTr
nweiz
2014/05/19 21:11:09
I'm going to use the pain of backwards incompatibi
|
| + final transformer; |
| /// The id of this transform's primary asset. |
| final AssetId primaryId; |
|
Bob Nystrom
2014/05/08 20:30:48
Mark this deprecated and add a String "key" getter
nweiz
2014/05/08 21:12:36
In the vast majority of cases this is going to be
|
| - TransformInfo(this.transformer, this.primaryId); |
| + TransformInfo(transformer, this.primaryId) |
| + : transformer = transformer is WrappingAggregateTransformer ? |
| + transformer.transformer : transformer; |
| bool operator==(other) => |
| other is TransformInfo && |