Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2673893002: Accept instance members and locals named "Function" (fixes #28610). (Closed)

Created:
3 years, 10 months ago by regis
Modified:
3 years, 10 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Accept instance members and locals named "Function" (fixes #28610). Add regression test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1ff4a5a16b8f452c0534d2a04347cdcde480e26f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M runtime/vm/parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A tests/language/regress_28610_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
regis
Matthias, You had correctly asked about this in the code review. I first had it ...
3 years, 10 months ago (2017-02-03 17:18:43 UTC) #2
siva
lgtm
3 years, 10 months ago (2017-02-03 17:54:38 UTC) #4
regis
Thanks Siva.
3 years, 10 months ago (2017-02-03 17:56:39 UTC) #5
regis
Committed patchset #1 (id:1) manually as 1ff4a5a16b8f452c0534d2a04347cdcde480e26f (presubmit successful).
3 years, 10 months ago (2017-02-03 17:58:44 UTC) #7
hausner
LGTM 2.
3 years, 10 months ago (2017-02-03 18:12:50 UTC) #8
regis
3 years, 10 months ago (2017-02-03 18:15:21 UTC) #9
Message was sent while issue was closed.
Thanks 2
:-)

Powered by Google App Engine
This is Rietveld 408576698