Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 2673833003: [interpreter] Create custom call opcodes for specific argument counts (Closed)
Patch Set: 32- and 64-bit ports Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index 9d77056c5c4215d11a15b200cef858102941aa34..0477afa2a8ee4e16c51e08e6354d0aa99b7f3968 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -890,7 +890,15 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::Call(Register callable,
call_type == Call::KEYED_PROPERTY_CALL) {
OutputCallProperty(callable, args, args.register_count(), feedback_slot);
rmcilroy 2017/02/06 12:20:01 Note - you aren't getting any benifit of these han
} else {
- OutputCall(callable, args, args.register_count(), feedback_slot);
+ if (args.register_count() == 1) {
+ OutputCall0(callable, args[0], feedback_slot);
+ } else if (args.register_count() == 2) {
+ OutputCall1(callable, args[0], args[1], feedback_slot);
+ } else if (args.register_count() == 3) {
+ OutputCall2(callable, args[0], args[1], args[2], feedback_slot);
+ } else {
+ OutputCall(callable, args, args.register_count(), feedback_slot);
+ }
}
} else {
DCHECK(tail_call_mode == TailCallMode::kAllow);

Powered by Google App Engine
This is Rietveld 408576698