[interpreter] Create custom call opcodes for specific argument counts

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include <fstream>
 #include <memory>
 
 #include "src/ast/prettyprinter.h"
@@ skipping 2066 matching lines @@
 //
 // Call a JSfunction or Callable in |callable| with the |receiver| and
 // |arg_count| arguments in subsequent registers. Collect type feedback into
 // |feedback_slot_id|. The callable is known to be a property of the receiver.
 void Interpreter::DoCallProperty(InterpreterAssembler* assembler) {
   // TODO(leszeks): Look into making the interpreter use the fact that the
   // receiver is non-null.
   DoJSCall(assembler, TailCallMode::kDisallow);
 }
 
+void Interpreter::DoCall0(InterpreterAssembler* assembler) {
+  Node* function_reg = __ BytecodeOperandReg(0);
+  Node* function = __ LoadRegister(function_reg);
+  Node* receiver_reg = __ BytecodeOperandReg(1);
+  Node* receiver_arg = __ RegisterLocation(receiver_reg);
+  Node* receiver = __ Load(MachineType::TaggedPointer(), receiver_arg);
+  Node* slot_id = __ BytecodeOperandIdxInt32(2);
+  Node* type_feedback_vector = __ LoadTypeFeedbackVector();
+  Node* context = __ GetContext();
+  Callable call_ic = CodeFactory::CallIC(isolate_);
+  Node* result = __ CallStub(call_ic, context, function, __ Int32Constant(0),
+                             slot_id, type_feedback_vector, receiver);

[rmcilroy, 2017/02/06 12:20:01]

Could we pull the shared logic out to a common helper function (either here or
in InterpreterAssembler) and just pass in the arity?

+  __ SetAccumulator(result);
+  __ Dispatch();
+}
+
+void Interpreter::DoCall1(InterpreterAssembler* assembler) {
+  Node* function_reg = __ BytecodeOperandReg(0);
+  Node* function = __ LoadRegister(function_reg);
+  Node* receiver_reg = __ BytecodeOperandReg(1);
+  Node* receiver_arg = __ RegisterLocation(receiver_reg);
+  Node* receiver = __ Load(MachineType::TaggedPointer(), receiver_arg);
+  Node* arg0_reg = __ BytecodeOperandReg(2);
+  Node* arg0 = __ LoadRegister(arg0_reg);
+  Node* slot_id = __ BytecodeOperandIdxInt32(3);
+  Node* type_feedback_vector = __ LoadTypeFeedbackVector();
+  Node* context = __ GetContext();
+  Callable call_ic = CodeFactory::CallIC(isolate_);
+  Node* result = __ CallStub(call_ic, context, function, __ Int32Constant(1),
+                             slot_id, type_feedback_vector, receiver, arg0);
+  __ SetAccumulator(result);
+  __ Dispatch();
+}
+
+void Interpreter::DoCall2(InterpreterAssembler* assembler) {
+  Node* function_reg = __ BytecodeOperandReg(0);
+  Node* function = __ LoadRegister(function_reg);
+  Node* receiver_reg = __ BytecodeOperandReg(1);
+  Node* receiver = __ LoadRegister(receiver_reg);
+  Node* arg0_reg = __ BytecodeOperandReg(2);
+  Node* arg0 = __ LoadRegister(arg0_reg);
+  Node* arg1_reg = __ BytecodeOperandReg(3);
+  Node* arg1 = __ LoadRegister(arg1_reg);
+  Node* slot_id = __ BytecodeOperandIdxInt32(4);
+  Node* type_feedback_vector = __ LoadTypeFeedbackVector();
+  Node* context = __ GetContext();
+  Callable call_ic = CodeFactory::CallIC(isolate_);
+  Node* result =
+      __ CallStub(call_ic, context, function, __ Int32Constant(2), slot_id,
+                  type_feedback_vector, receiver, arg0, arg1);
+  __ Comment("SetAccumulator");

[rmcilroy, 2017/02/06 12:20:01]

unintended comment?

+  __ SetAccumulator(result);
+  __ Dispatch();
+}
+
 // TailCall <callable> <receiver> <arg_count> <feedback_slot_id>
 //
 // Tail call a JSfunction or Callable in |callable| with the |receiver| and
 // |arg_count| arguments in subsequent registers. Collect type feedback
 // into |feedback_slot_id|
 void Interpreter::DoTailCall(InterpreterAssembler* assembler) {
   DoJSCall(assembler, TailCallMode::kAllow);
 }
 
 // CallRuntime <function_id> <first_arg> <arg_count>
@@ skipping 1202 matching lines @@
   __ StoreObjectField(generator, JSGeneratorObject::kContinuationOffset,
       __ SmiTag(new_state));
   __ SetAccumulator(old_state);
 
   __ Dispatch();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8