Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2455)

Unified Diff: cc/test/layer_test_common.cc

Issue 2673813002: Changes the bounds being sent for occlusion from physical pixels to DIP (Closed)
Patch Set: Resolving comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_test_common.cc
diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc
index a6753ce9f528179e7f340af03182e9ca2924a140..6398fcb37d827afe77c8f0e5a5d79dcd718af717 100644
--- a/cc/test/layer_test_common.cc
+++ b/cc/test/layer_test_common.cc
@@ -48,9 +48,11 @@ void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads,
Region remaining = rect;
for (auto iter = quads.cbegin(); iter != quads.cend(); ++iter) {
+ EXPECT_TRUE(iter->rect.Contains(iter->visible_rect));
danakj 2017/02/10 20:35:44 In order to exactly cover, would the rects not nee
malaykeshav 2017/02/10 21:02:50 I think its: all the |quads| (visible) combined sh
danakj 2017/02/10 22:06:45 OK I think you're right, and checking that the vis
+
gfx::RectF quad_rectf = MathUtil::MapClippedRect(
iter->shared_quad_state->quad_to_target_transform,
- gfx::RectF(iter->rect));
+ gfx::RectF(iter->visible_rect));
// Before testing for exact coverage in the integer world, assert that
// rounding will not round the rect incorrectly.
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698