cc/test/layer_test_common.cc - Issue 2673813002: Changes the bounds being sent for occlusion from physical pixels to DIP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/layer_test_common.cc

Issue 2673813002: Changes the bounds being sent for occlusion from physical pixels to DIP (Closed)

Patch Set: Use gfx::ScaleToEnclosingRect instead of gfx::ScaleToEnclosedRect Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/test/layer_test_common.cc

diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc

index a6753ce9f528179e7f340af03182e9ca2924a140..30fad17f7872e821a6a7a813ca2f052d4e1cf8d9 100644

--- a/cc/test/layer_test_common.cc

+++ b/cc/test/layer_test_common.cc

@@ -50,7 +50,7 @@ void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads,

for (auto iter = quads.cbegin(); iter != quads.cend(); ++iter) {

gfx::RectF quad_rectf = MathUtil::MapClippedRect(

iter->shared_quad_state->quad_to_target_transform,

- gfx::RectF(iter->rect));

+ gfx::RectF(iter->visible_rect));

danakj 2017/02/10 16:32:22 Should this verify quad rect /and/ visible rect?

malaykeshav 2017/02/10 20:24:58 Done

// Before testing for exact coverage in the integer world, assert that

// rounding will not round the rect incorrectly.