MD Settings: Add Protected Content toggle to Site Settings

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index e7ef19bd5a62d1c3c50c0d629e0eec8ef8e610b2..3d0f5f073c9eefff2bb273c98bc9da3653b48f6f 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -437,6 +437,19 @@
           </site-data-details-subpage>
         </settings-subpage>
       </template>
+<if expr="chromeos or is_win">
+      <template is="dom-if" route-path="/content/protectedContent">

[dpapad, 2017/02/03 22:20:14]

Is this worth a test? There are quite a few site-settings related tests, perhaps
adding one will not have too much overhead?
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cr_setti...

[tommycli, 2017/02/03 22:50:51]

Well... since there's no real logic to this section, I feel like a test would be
basically testing site-toggle-button and (in the next CL)
category-settings-exceptions, both which individually have tests.

feel free to disagree, and i'll be happy to write a test for this subpage.

[dpapad, 2017/02/03 23:06:20]

Explanation is good enough for me.

+        <settings-subpage page-title="$i18n{siteSettingsProtectedContent}"
+            no-search>

[dpapad, 2017/02/03 22:20:14]

The no-search attribute should be on the template, not here. Such that the
searching algorinthm, will not even bother force rendering this template, when a
search occurs.


BTW, I am realizing that we could improve our tests to catch such cases
(forgetting to add no-search or associated-control). I'll make a note and see if
I can add such a test in the future. Basically load chrome://md-settings, search
for "a" (assuming there will be an occurrence in every single section), ensure
there are no exceptions and that searching completes successfully.

[tommycli, 2017/02/03 22:50:51]

Done.

+          <div class="settings-box first">
+            <settings-toggle-button class="start"
+                pref="{{prefs.settings.privacy.drm_enabled}}"
+                label="$i18n{siteSettingsProtectedContentEnable}">
+            </settings-toggle-button>
+          </div>
+        </settings-subpage>
+      </template>
+</if>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>