net/url_request/url_request_unittest.cc - Issue 2673753004: Fix set_up_quic_server_info_factory in HttpCache creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2673753004: Fix set_up_quic_server_info_factory in HttpCache creation (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_unittest.cc

diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc

index dd2b713221128b79adb22cab2624b552cc6bca7e..6eb555488388f41de2df35593f8101f12b093294 100644

--- a/net/url_request/url_request_unittest.cc

+++ b/net/url_request/url_request_unittest.cc

@@ -7737,7 +7737,7 @@ TEST_F(URLRequestTestHTTP, NetworkSuspendTest) {

network_layer->OnSuspend();

HttpCache http_cache(std::move(network_layer),

- HttpCache::DefaultBackend::InMemory(0), true);

+ HttpCache::DefaultBackend::InMemory(0), false);

Ryan Hamilton 2017/02/03 19:56:36 nit: can you comment this boolean literal?

Zhongyi Shi 2017/02/03 20:03:21 Done.

TestURLRequestContext context(true);

context.set_http_transaction_factory(&http_cache);