third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js - Issue 2673733003: DevTools: Speed up timeline aggregated tree building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

Issue 2673733003: DevTools: Speed up timeline aggregated tree building. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/category-filter.html » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

index cc63fedc203e39ed3bbbc6b28a0a5fbf42674118..e2ab4794e875cef26f7c24bb16336c85eb5ee178 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js

@@ -226,8 +226,7 @@ InspectorTest.walkTimelineEventTreeUnderNode = function(callback, root, level)

var event = root.event;

if (event)

callback(event, level)

- var children = root.children ? root.children.values() : [];

- for (var child of children)

+ for (var child of root.children().values())

InspectorTest.walkTimelineEventTreeUnderNode(callback, child, (level || 0) + 1);

}