Split core file tracking functionality from AnalysisDriver.

Split core file tracking functionality from AnalysisDriver.

This file tracking functionality will be re-used for incremental
compilation.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b95f37612a5a87cafac8c2e6ef4ae2ccde1328f3

[Paul Berry, 2017-02-02 21:26:39]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-02-02 21:52:17]

LGTM

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:439: var addedFiles =
_fileTracker.addedFiles;
Type?

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:690: return
_fileTracker.logger.run('Compute analysis result for $path', () {
Accessing logger from _fileTracker seems a bit cumbersome.
Why not keep a reference in the driver?

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:912:
_fileTracker.fileWasAnalyzed(path);
This code will be executed even if result == null, when we have a part without a
library.

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_tracker.dart (right):

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_tracker.dart:29: * which have been
impacted by a change, and thus need analysis.
It is more precise to say "might have been impacted".

[Paul Berry, 2017-02-02 22:22:19]

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:439: var addedFiles =
_fileTracker.addedFiles;
On 2017/02/02 21:52:17, scheglov wrote:
> Type?

Done.

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:690: return
_fileTracker.logger.run('Compute analysis result for $path', () {
On 2017/02/02 21:52:17, scheglov wrote:
> Accessing logger from _fileTracker seems a bit cumbersome.
> Why not keep a reference in the driver?

Done.

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:912:
_fileTracker.fileWasAnalyzed(path);
On 2017/02/02 21:52:17, scheglov wrote:
> This code will be executed even if result == null, when we have a part without
a
> library.

Ah, I see.  Good catch.  Fixed.

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_tracker.dart (right):

https://codereview.chromium.org/2673683003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_tracker.dart:29: * which have been
impacted by a change, and thus need analysis.
On 2017/02/02 21:52:17, scheglov wrote:
> It is more precise to say "might have been impacted".

Done.

[Paul Berry, 2017-02-02 23:03:42]

Description was changed from

==========
Split core file tracking functionality from AnalysisDriver.

This file tracking functionality will be re-used for incremental
compilation.
==========

to

==========
Split core file tracking functionality from AnalysisDriver.

This file tracking functionality will be re-used for incremental
compilation.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b95f37612a5a87cafac8c2e6ef4ae2ccde1328f3
==========

[Paul Berry, 2017-02-02 23:03:43]

Committed patchset #1 (id:1) manually as
b95f37612a5a87cafac8c2e6ef4ae2ccde1328f3 (presubmit successful).