Issue 267363011: Build fix after r173654

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267363011: Build fix after r173654 (Closed)

Created:
6 years, 7 months ago by mnaganov (inactive)

Modified:
6 years, 7 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Build fix after r173654 The change https://codereview.chromium.org/270553005/ doesn't update inspector.html after moving TracingModel.js. This breaks devtools_frontend_resources target BUG=361045 TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173655

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/inspector.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

Committed patchset #1 manually as r173655 (presubmit successful).

6 years, 7 months ago (2014-05-08 17:05:48 UTC) #1

yurys

6 years, 7 months ago (2014-05-08 19:00:39 UTC) #2

Message was sent while issue was closed.

Thanks for fixing this! I had it fixed locally but forgot to upload the latest
version of the patch before committing :(

Expand Messages | Collapse Messages